New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with add columns on tables failing if using both after and collate #2432

Merged
merged 2 commits into from Jan 24, 2018

Conversation

Projects
None yet
3 participants
@tmeinders
Contributor

tmeinders commented Jan 18, 2018

No description provided.

@kibertoad

This comment has been minimized.

Collaborator

kibertoad commented Jan 18, 2018

@tmeinders How difficult would it be to add a test?

@elhigu

Thank you for the contribution! As @kibertoad test case is missing. This cannot be merged without having one.

@tmeinders

This comment has been minimized.

Contributor

tmeinders commented Jan 23, 2018

I'd be happy to make some tests. At the moment though, I've not been able to get the tests running smoothly. I run into this right now and haven't had a chance to dig into it:

Knex:warning - Connection Error: Connection ended unexpectedly
Knex:warning - Connection Error: Connection ended unexpectedly
                ✓ connection pool can query x10 (43ms)
>> Destroying container
#~ Stopped container c081510155435ce7aa53e2d4ca27e05fe1eda19a4fe4f468be37c936ab16ae69
#~ Removed container c081510155435ce7aa53e2d4ca27e05fe1eda19a4fe4f468be37c936ab16ae69

  mariadb | mariasql
Knex:warning - Connection Error: Error: Can't connect to MySQL server on '127.0.0.1' (61 "Connection refused")
Knex:warning - Connection Error: Error: Can't connect to MySQL server on '127.0.0.1' (61 "Connection refused")
    1) "before all" hook

  760 passing (3m)
  1 failing

  1) mariadb | mariasql "before all" hook:
     select * from information_schema.tables where table_name = 'knex_migrations_lock' and table_schema = database() - Can't connect to MySQL server on '127.0.0.1' (61 "Connection refused")
  Error: Can't connect to MySQL server on '127.0.0.1' (61 "Connection refused")

If you know off the top of your head what might resolve this, let me know.

@elhigu

This comment has been minimized.

Collaborator

elhigu commented Jan 23, 2018

Do you have mariadb/mysql running with root user withoit password and with knex_test database created? Also you can choose to which dbs run the tests wit DB environment parameter. Check for example travis configuration file.

@tmeinders

This comment has been minimized.

Contributor

tmeinders commented Jan 23, 2018

Ah I was making some incorrect assumptions about docker's use in these tests. I was able to add a couple tests and run them against my own mysql setup. Let me know if there is anything to be improved for these tests (organizational or coverage). If there is a guide to point me to for running and adding tests to satisfy pull requests for this project, I'll happily comply. Thanks for the support so far!

@elhigu

elhigu approved these changes Jan 24, 2018

@elhigu

This comment has been minimized.

Collaborator

elhigu commented Jan 24, 2018

Perfect. Thank you!

@elhigu elhigu merged commit c1997e9 into tgriesser:master Jan 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment