New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop executing tests on Node 4 and 5, update documentation. #2451

Merged
merged 7 commits into from May 3, 2018

Conversation

Projects
None yet
4 participants
@igor-savin-ht
Contributor

igor-savin-ht commented Feb 2, 2018

No description provided.

@igor-savin-ht igor-savin-ht changed the title from general: stop executing tests on Node 4 and 5, update documentation. to stop executing tests on Node 4 and 5, update documentation. Feb 2, 2018

@igor-savin-ht

This comment has been minimized.

Contributor

igor-savin-ht commented Feb 2, 2018

Related to #2450

@igor-savin-ht

This comment has been minimized.

Contributor

igor-savin-ht commented Feb 2, 2018

@elhigu Given that no code was changed, I presume that failure is due to flaky tests. Is there a way to trigger tests again, or should I just make a dummy commit.

@elhigu

This comment has been minimized.

Collaborator

elhigu commented Feb 19, 2018

Lets apply this a bit later when when node 4 LTS period ends.

@capaj

This comment has been minimized.

Contributor

capaj commented Feb 22, 2018

@igor-savin-ht let's add engines to package.json while we're at it: igor-savin-ht#1

@igor-savin-ht

This comment has been minimized.

Contributor

igor-savin-ht commented Feb 22, 2018

@capaj Will do!

igor-savin-ht added some commits Feb 22, 2018

Merge pull request #1 from capaj/patch-4
adds engines to package.json
@igor-savin-ht

This comment has been minimized.

Contributor

igor-savin-ht commented Apr 27, 2018

@elhigu Considering that 0.15 is incoming, probably now is the good time to merge this?

igor-savin-ht added some commits Apr 27, 2018

Don't run tests on Node 10 yet
No prebuilt Oracle driver for Node 10 yet: oracle/node-oracledb#901
@kibertoad

This comment has been minimized.

Collaborator

kibertoad commented Apr 27, 2018

@elhigu Given that tests pass and linting pass, any ideas why build on Node 6 could have failed?..

@elhigu

This comment has been minimized.

Collaborator

elhigu commented Apr 27, 2018

Segmentation fault (core dumped) I've seen that every now and then. I don't know where it comes, I just hit restart button for node 6.

@elhigu elhigu merged commit 4a6d287 into tgriesser:master May 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment