Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stress test, which uses TCP proxy to simulate flaky connections #2460

Merged
merged 6 commits into from Feb 16, 2018

Conversation

Projects
None yet
1 participant
@elhigu
Copy link
Collaborator

elhigu commented Feb 10, 2018

Shows #2443 crash (and earlier pool versions memory leaks with postgres).

Shows also some edge cases when connections are broken e.g. during ending connection because of timeout etc.

Removes copy-paste from mysql2 driver.

Fixes mysql driven create / destroy connection functionality.

@elhigu elhigu force-pushed the stress-test-showing-mysql2-crash branch from 589e94e to 535a61d Feb 16, 2018

Fixed mysql acquire connection and destroy conneciton code
Acquire connection did bind error handler too late and didn't free it on success. Destroy did free event listeners before connection end was called, so error during connection end leaked out.

@elhigu elhigu force-pushed the stress-test-showing-mysql2-crash branch from 535a61d to 402be73 Feb 16, 2018

@elhigu elhigu merged commit e250260 into master Feb 16, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.