New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of create table if not exist from migration api #2473

Merged
merged 1 commit into from Feb 16, 2018

Conversation

Projects
None yet
2 participants
@elhigu
Collaborator

elhigu commented Feb 16, 2018

No description provided.

Removed unnecessary createTableIfNotExist and replaced with createTable
It is already tested in upper level that table wasn't there if this method is called.

@elhigu elhigu merged commit 7ff766f into tgriesser:master Feb 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -154,7 +154,7 @@ export default class Migrator {
// Create the migration table, if it doesn't already exist.

This comment has been minimized.

@joelmukuthu

joelmukuthu Feb 16, 2018

Contributor

the problem with comments in code :)

This comment has been minimized.

@elhigu

elhigu Feb 19, 2018

Collaborator

True 👍 should be few lines above.

This comment has been minimized.

@elhigu

elhigu Feb 19, 2018

Collaborator

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment