New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added npm run test:oracledb command that runs oracledb tests in docker #2491

Merged
merged 1 commit into from Feb 20, 2018

Conversation

Projects
None yet
2 participants
@elhigu
Collaborator

elhigu commented Feb 19, 2018

Also cleaned up some old docker configurations from test knexfile

Helps debugging #2476

Added npm run test:oracledb command that runs oracledb tests in docker
Also cleaned up some old docker configurations from test knexfile
"prepublish": "npm run babel",
"pre_test": "npm run lint",
"tape": "node test/tape/index.js | tap-spec",
"debug_tape": "node-debug test/tape/index.js",
"test": "npm run pre_test && istanbul --config=test/.istanbul.yml cover node_modules/mocha/bin/_mocha -- --check-leaks -t 10000 -b -R spec test/index.js && npm run tape",
"test:oracledb": "docker rmi -f --no-prune knex-test-oracledb && docker build -f scripts/oracle-tests-Dockerfile --tag knex-test-oracledb . && docker run -i -t knex-test-oracledb",

This comment has been minimized.

@elhigu

elhigu Feb 20, 2018

Collaborator

I think I will change this to be named: oracledb:test I'm making PR tomorrow for running mssql tests too (they seem to be failing currently though) and those npm scripts are named mssql:init (start/rebuild db), mssql:test, mssql:destroy (stop db).

This comment has been minimized.

@wubzz

wubzz Feb 20, 2018

Collaborator

This is awesome. 👍

This comment has been minimized.

@elhigu

elhigu Feb 20, 2018

Collaborator

I'll update task name in mssql PR

@elhigu elhigu merged commit ece2da1 into tgriesser:master Feb 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
CMD /usr/sbin/startup.sh && \
cd knex && \
npm install && \
npm install oracledb && \

This comment has been minimized.

@wubzz

wubzz Feb 21, 2018

Collaborator

@elhigu I think npm install sqlite3 is needed too since ENV DB "sqlite3 oracledb".

Was able to run this eventually (new to docker) in Windows environment, but stumbled upon sqlite3 module not installed when it started running tests.

Strangely enough some sqlite3 tests were failing too on master, investigating..

This comment has been minimized.

@elhigu

elhigu Feb 21, 2018

Collaborator

Yeah it might be that sqlite is always required for tests.

I actually added it because there was some strange segmentation faults happening after running tests. I was able to get rid of them by removing --leak-check flag from plaintest script. I'll try to remove sqlite testing from there or add it to npm install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment