Join GitHub today
Removed semicolon from rollback stmt for oracle #2564
@elhigu Interesting, it was failing for 2 platforms when I submitted (node 4 & 8, I think) but everything seems to pass now. It recovered overnight :)
Also still curious how come I stumbled upon this since this should have been encountered by now by other oracledb users
Now playing around with the knex itself. Looks like
Jun 18, 2018
1 check passed
Sure, we also need to simplify a lot of the internals as well. I'll add a failing case in fixing this.
@elhigu Yeah I don't even think that the oracle driver uses this codepath, they seem to have their own transaction implementation internal to the connection? It's all a little tough to follow, seems a lot of this can be simplified.