New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing connection override to a query #2817

Merged
merged 6 commits into from Sep 26, 2018

Conversation

Projects
None yet
2 participants
@kibertoad
Copy link
Collaborator

kibertoad commented Sep 24, 2018

implements #2804

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Sep 24, 2018

@elhigu If this looks OK, I'll also prepare a documentation PR.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Sep 26, 2018

@elhigu Any chance reviewing this could be prioritized? We were suddenly hit with a weird behavior of Google Cloud SQL and this is the only way to work around it, and using private forks in production is typically a terrible idea.

kibertoad added some commits Sep 26, 2018

Merge branch 'master' of https://github.com/tgriesser/knex into featu…
…re/2804-passing-connection

# Conflicts:
#	test/unit/knex.js
@elhigu

This comment has been minimized.

Copy link
Collaborator

elhigu commented Sep 26, 2018

I would love to get this in. This will add support to lots of stuff that can be done with knex when one can choose to use the same connection for multiple queries without using transactions.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Sep 26, 2018

Documentation added, tests pass after latest fix to the master. Are there any gotchas to handling connections inside Knex that I am not aware of and that are relevant to this change?

@elhigu

This comment has been minimized.

Copy link
Collaborator

elhigu commented Sep 26, 2018

I forgot to merge this for next release... I'll do another one 😅

@kibertoad kibertoad referenced this pull request Sep 26, 2018

Merged

Fix ES6 support #2821

@elhigu elhigu merged commit 8c87650 into tgriesser:master Sep 26, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.06%) to 84.82%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kibertoad kibertoad deleted the JakeGinnivan:feature/2804-passing-connection branch Sep 26, 2018

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Sep 26, 2018

woohoo! thanks a lot!

@elhigu

This comment has been minimized.

Copy link
Collaborator

elhigu commented Sep 26, 2018

done!

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Sep 26, 2018

Great news, thank you so much!

@elhigu

This comment has been minimized.

Copy link
Collaborator

elhigu commented Sep 26, 2018

Maybe after oracledb is fixed again we could think about real release... gotta go through which pull requests are still in progress.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Sep 26, 2018

Sounds good! I guess #2608 is probably one of the most important not-yet-merged PRs, but looks like it was abandoned and no tests are coming :(. Fixing the regression for PostgreSQL streaming error handling (#2638) would also be nice, I guess. @fcmatteo any chance you could have some time to take a look at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment