New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw instead of process.exit when client module missing #2843

Merged
merged 3 commits into from Oct 8, 2018

Conversation

Projects
None yet
2 participants
@danderson00
Copy link
Contributor

danderson00 commented Oct 8, 2018

A couple of things -

  • The test relies on the oracle module not being in devDependencies. It will fail if it is ever added.
  • I added the test to test/unit/knex.js, but I don't think the tests in this file are being run. I can't see the output for any of the tests in this file.
@danderson00

This comment has been minimized.

Copy link
Contributor

danderson00 commented Oct 8, 2018

* being run when npm test is executed from the command line. Waiting for CI to run and see the results.

@danderson00

This comment has been minimized.

Copy link
Contributor

danderson00 commented Oct 8, 2018

Resolves #2743. Not sure about failures. Looks like mssql failures from the build log, and not sure why code coverage should fall?

@wubzz

This comment has been minimized.

Copy link
Collaborator

wubzz commented Oct 8, 2018

The coverage CI is super wonky. Don't know why, but if I had to guess I would say because of webpack -> output differs everytime.

Same in one of my PRs. I added 5 tests and barely any changes to the source, yet it decreased by like 1%..

So the gist of it is I'm personally ignoring it.

Thanks for this!

@wubzz wubzz merged commit 46dbe91 into tgriesser:master Oct 8, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.02%) to 84.68%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment