New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage types internally #2845

Merged
merged 3 commits into from Oct 8, 2018

Conversation

Projects
None yet
4 participants
@tgriesser
Copy link
Owner

tgriesser commented Oct 8, 2018

Copying the knex type definitions from DefinitelyTyped into the project.

Putting these here will be useful since we can update them as new API's are merged.

tgriesser added some commits Oct 8, 2018

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Oct 8, 2018

@tgriesser @JakeGinnivan Probably we should also include types from DefinitelyTyped/DefinitelyTyped#29256

@tgriesser tgriesser merged commit b2450a9 into master Oct 8, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 84.68%
Details
@tgriesser

This comment has been minimized.

Copy link
Owner

tgriesser commented Oct 8, 2018

Cool, yeah. I'll merge this and then @JakeGinnivan if you want to open a PR here with the updated types we can merge that.

@JakeGinnivan

This comment has been minimized.

Copy link
Contributor

JakeGinnivan commented Oct 16, 2018

@tgriesser will get it done, thanks!

@serprex

This comment has been minimized.

Copy link
Contributor

serprex commented Dec 11, 2018

Type definitions lack support for { alias: column } in joins & toSQL on Knex.Raw. I'll open a PR when I have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment