New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the wrapValue function to allow for array column operations #287

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@ericeslinger
Contributor

ericeslinger commented May 28, 2014

This is probably not the general-purpose solution to the problem I'm encountering, but it solves my issues. I need to do a join on table.array_column[1] = value, but the existing wrapValue process turns that into "table"."array_column[1]" instead of "table"."array_column"[1]. This seemed like the best place to find that case and fix it.

In where clauses, I could do a whereRaw to brute-force the double-quotes, but there doesn't seem to be a similar functionality in join clauses. That would be another way to solve this problem, though - allow for a join(this.raw("stuff")) (which currently throws a toLowerCase error when compileJoins tries to lowercasify the Raw.

tgriesser added a commit that referenced this pull request May 29, 2014

@tgriesser

This comment has been minimized.

Owner

tgriesser commented Jun 4, 2014

Taken care of in 0.6 - let me know if it doesn't seem to work.

@tgriesser tgriesser closed this Jun 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment