New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup based on analysis by https://lgtm.com #2870

Merged
merged 2 commits into from Oct 22, 2018

Conversation

Projects
None yet
2 participants
@kibertoad
Copy link
Collaborator

kibertoad commented Oct 21, 2018

No description provided.

@@ -184,7 +184,7 @@ assign(QueryCompiler_Oracle.prototype, {
}

// always wrap returning argument in array
if (returning && !Array.isArray(returning)) {
if (!Array.isArray(returning)) {

This comment has been minimized.

@kibertoad

kibertoad Oct 21, 2018

Collaborator

it returns early in previous statement if truthy

@@ -160,8 +160,6 @@ _.assign(Oracledb_Compiler.prototype, {

sql.outBinding = outBinding;
if (returning[0] === '*') {
returning = returning.slice(0, -1);

This comment has been minimized.

@kibertoad

kibertoad Oct 21, 2018

Collaborator

not used

@@ -251,8 +251,7 @@ assign(Client_MSSQL.prototype, {

// Grab a connection, run the query via the MSSQL streaming interface,
// and pass that through to the stream we've sent back to the client.
_stream(connection, obj, stream, options) {
options = options || {};

This comment has been minimized.

@kibertoad

kibertoad Oct 21, 2018

Collaborator

not used

@elhigu elhigu merged commit c00ddd5 into master Oct 22, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 84.708%
Details

@kibertoad kibertoad deleted the fix/cleanup-lgtm-warnings branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment