New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2915 Oracledb tests are failing #2924

Merged
merged 3 commits into from Nov 23, 2018

Conversation

Projects
None yet
3 participants
@kamote
Copy link
Contributor

kamote commented Nov 22, 2018

Fixes for GH-2915

  • fixes union failing tests
  • increment() and decrement() empty query issue

kamote added some commits Nov 22, 2018

GH-2915 Oracledb tests are failing
- fixes oracledb failing tests

@kamote kamote referenced this pull request Nov 22, 2018

Closed

Oracledb tests are failing #2915

})
.then(function(data) {
// Clean up lock for other tests
return knex('knex_migrations_lock').update({ is_locked: 0 });

This comment has been minimized.

@kibertoad

kibertoad Nov 22, 2018

Collaborator

any ideas why this only remains locked for Oracle? I wonder if something with transactions is wrong

This comment has been minimized.

@kamote

kamote Nov 22, 2018

Contributor

@kibertoad sometimes this is failing sometimes not, not very consistent.

This comment has been minimized.

@kamote

This comment has been minimized.

@elhigu

elhigu Nov 23, 2018

Collaborator

I was also suspecting that oracle's transaction code has something done wrong. I tried to look into it some months ago, but wasn't able to reproduce nor fix it.

It would be important to still add comment about how to make testbench to fail again to be able to really fix the underlying problem in oracle. And to add bug report issue to github pointing to disabled test.

This comment has been minimized.

@kibertoad

kibertoad Nov 23, 2018

Collaborator

Done. Could you please check if this is what you've had in mind or if we are still missing something?

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Nov 22, 2018

@elhigu Two runs still failed with sh: line 1: 659 Segmentation fault (core dumped) mocha --exit -t 10000 -b -R spec test/index.js -> I think it used to happen randomly before as well. Any ideas what we can do about it?

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Nov 22, 2018

@kamote Looks like we can move node 11 and node 10 from "allow_failures:" to main set in travis.yaml

@elhigu

This comment has been minimized.

Copy link
Collaborator

elhigu commented Nov 23, 2018

sh: line 1: 659 Segmentation fault (core dumped) mocha --exit -t 10000 -b -R spec test/index.js

For that there is pretty much nothing we can do, except start using different docker setup for oracle.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Nov 23, 2018

For that there is pretty much nothing we can do, except start using different docker setup for oracle.

So the solution would be to just keep merging PRs when we see Travis build only failing for this reason? Shall I already create a PR to make Oracle tests mandatory already?

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Nov 23, 2018

@kamote

This comment has been minimized.

Copy link
Contributor

kamote commented Nov 23, 2018

@kibertoad @elhigu I also got this errors randomly on local... 1/5 during the consecutive test

 937 passing (10s)
  1 failing

  1) oracle | oracledb
       Inserts
         batchInsert
           "before each" hook for "transaction.batchInsert using specified transaction":
     begin execute immediate 'drop table "BatchInsert"'; exception when others then if sqlcode != -942 then raise; end if; end; - ORA-00054: resource busy and acquire with NOWAIT specified or timeout expired
ORA-06512: at line 1
ORA-06512: at line 1
  Error: ORA-00054: resource busy and acquire with NOWAIT specified or timeout expired
  ORA-06512: at line 1
  ORA-06512: at line 1
      at Connection.connection.executeAsync (lib/dialects/oracledb/index.js:203:16)
      at /Users/kamote/Documents/GitHub/knex/lib/dialects/oracledb/index.js:295:16
  From previous event:
      at Client_Oracledb._query (lib/dialects/oracledb/index.js:282:10)
      at Client_Oracledb.query (lib/client.js:192:17)
      at Runner.<anonymous> (lib/runner.js:138:36)
  From previous event:
      at Runner.queryArray (lib/runner.js:205:40)
      at /Users/kamote/Documents/GitHub/knex/lib/runner.js:44:23
  From previous event:
      at Runner.run (lib/runner.js:33:30)
      at SchemaBuilder.Target.then (lib/interface.js:23:43)
      at Context.<anonymous> (test/integration/builder/inserts.js:1116:61)

@kibertoad kibertoad merged commit ab35e97 into tgriesser:master Nov 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 84.89%
Details
@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Nov 23, 2018

@kamote Thanks!

@elhigu

This comment has been minimized.

Copy link
Collaborator

elhigu commented Nov 23, 2018

@kamote if that keeps on failing lets see what to do about it.

mwilliammyers added a commit to voxjar/knex that referenced this pull request Dec 12, 2018

tgriesserGH-2915 Oracledb tests are failing (tgriesser#2924)
* tgriesserGH-2915 Oracledb tests are failing

- fixes oracledb failing tests

* Fixes oracledb increment() and decrement() empty query

- Error: The query is empty

* Add ToDo for fixing Oracle bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment