Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typings #2960

Merged
merged 5 commits into from Jan 4, 2019

Conversation

Projects
None yet
3 participants
@serprex
Copy link
Contributor

commented Dec 17, 2018

Updated the typings with ways which knex's API seems to allow for given our existing code. These were previously not covered by DefinitelyTyped

serprex and others added some commits Dec 17, 2018

Merge pull request #1 from serprex/fix-typings
Fixed JoinRaw, RawQueryBuilder and RawBuilder interfaces.
@AmauriAires

This comment has been minimized.

Copy link

commented Jan 4, 2019

I reviewed it and made a few changes. It should work properly now.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jan 4, 2019

Thanks!

@kibertoad kibertoad merged commit 83fcefe into tgriesser:master Jan 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.08%) to 84.943%
Details
@AmauriAires

This comment has been minimized.

Copy link

commented Jan 4, 2019

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.