Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Typescript type definition for `.asCallback()` #2963
In Knex version 0.16.2,
we are using Knex.js with Typescript + callback style code.
As I upgrade Knex version 0.15.0 -> 0.16.2, now it cannot be compiled typescript files anymore because of no type definition for
Therefore, I added
@elhigu Knex.js manages type definition in its own repo, but Bluebird manages their type definition in DefinitelyTyped repo. https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/bluebird/index.d.ts
So, users who use Knex.js in Typescript but haven't downloaded DefinitelyTyped type definition of Bluebird might have the same issue with me.
@elhigu I have found what is wrong.
In Knex@0.16.2, there's no "@types/bluebird" dependencies.
In Knex@0.16.3, there is type dependency for "@types/bluebird".
I tried this in Knex@0.16.2, so it was a problem. and tried to compile in 0.16.3 it has no problem.
So this PR has no meaning :(