Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "constraintName" arg to TS definition #3006

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
2 participants
@fmenegossi
Copy link
Contributor

fmenegossi commented Jan 21, 2019

Add constraintName optional argument to TableBuilder.primary() TypeScript definition.
Currently, if you give the second argument, TS will tell that primary() expects only 1 argument, when in fact it supports the second optional argument to define the constraint name into the database.

Add "constraintName" arg to TS definition
Add constraintName optional argument to TableBuilder.primary() TypeScript definition.
Currently, if you give the second argument, TS will tell that primary() expects only 1 argument, when in fact it supports the second optional argument to define the constraint name into the database.

@kibertoad kibertoad merged commit 4f8cf79 into tgriesser:master Jan 22, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 84.945%
Details
@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Jan 22, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.