Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemaName is missing in MigratorConfig typings #3016

Merged
merged 2 commits into from Jan 28, 2019

Conversation

Projects
None yet
3 participants
@mmouterde
Copy link
Contributor

mmouterde commented Jan 28, 2019

add a schemaName value to MigratorConfig.

schemaName is missing in MigratorConfig typings
add a schemaName value to MigratorConfig.
@@ -829,6 +829,7 @@ declare namespace Knex {
extension?: string;
tableName?: string;
disableTransactions?: boolean;
schemaName?: string;

This comment has been minimized.

Copy link
@kibertoad

kibertoad Jan 28, 2019

Collaborator

since you are changing it anyway, could you please also add

sortDirsSeparately : optional boolean
and update directory one to support both String and String[]?

This comment has been minimized.

Copy link
@mmouterde

mmouterde Jan 28, 2019

Author Contributor

Absolutely !

There is other diff with Doc :

  • loadExtensions, migrationSource are in doc, not in code
  • database is in code, not in doc.
update MigratorConfig typings
- change type of `directory` from `string` to `string | string[]`
- add `sortDirsSeparately` as boolean optional config.

@kibertoad kibertoad merged commit a2b7e0e into tgriesser:master Jan 28, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 84.945%
Details
@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Jan 28, 2019

Thanks a lot! Would be nice to address these discrepancies too.

@mmouterde

This comment has been minimized.

Copy link
Contributor Author

mmouterde commented Jan 30, 2019

@kibertoad Do you plan to release a version including this PR ?

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Jan 30, 2019

Unfortunately, I don't have permissions to publish knex artefacts. @elhigu would be a better person to ask.

@elhigu

This comment has been minimized.

Copy link
Collaborator

elhigu commented Jan 31, 2019

I just published 0.16.4-next1 pre-release for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.