Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add intersect() #3023

Merged
merged 3 commits into from Mar 3, 2019

Conversation

Projects
None yet
3 participants
@thekuom
Copy link
Contributor

thekuom commented Jan 31, 2019

Addresses #2064

I needed INTERSECT for one of my projects so I used the existing UNION as a model, since they are extremely similar. Thanks for the great library!

@thekuom thekuom referenced this pull request Jan 31, 2019

Open

add intersect method #173

@thekuom

This comment has been minimized.

Copy link
Contributor Author

thekuom commented Jan 31, 2019

Documentation PR: knex/documentation#173

@thekuom thekuom force-pushed the thekuom:master branch from d2f7036 to 1c94329 Feb 9, 2019

@elhigu
Copy link
Collaborator

elhigu left a comment

Some tests verifying that generated queries actually works against real databases should be added.

Show resolved Hide resolved test/integration/builder/unions.js

@thekuom thekuom force-pushed the thekuom:master branch from 1c94329 to 1ed0f36 Mar 3, 2019

Show resolved Hide resolved test/unit/query/builder.js Outdated
Show resolved Hide resolved test/unit/query/builder.js Outdated
Show resolved Hide resolved types/knex.d.ts Outdated
@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Mar 3, 2019

Looks good, thank you!

@kibertoad kibertoad merged commit 71e097b into tgriesser:master Mar 3, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 85.227%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.