Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update enum arguments to reflect latest signature #3043

Merged
merged 2 commits into from Mar 3, 2019

Conversation

Projects
None yet
2 participants
@willsoto
Copy link
Contributor

willsoto commented Feb 10, 2019

Reimplemented from DefinitelyTyped/DefinitelyTyped#29946

Looks like this was lost when the typings were transferred to the repo.

@@ -850,6 +849,11 @@ declare namespace Knex {
now(): Raw;
}

interface EnumOptions {

This comment has been minimized.

Copy link
@kibertoad

kibertoad Mar 3, 2019

Collaborator

Can you also add boolean existingType that PostgreSQL supports?

This comment has been minimized.

Copy link
@kibertoad

kibertoad Mar 3, 2019

Collaborator

nvm, added myself :)

Update knex.d.ts
Add missing option for PostgreSQL

@kibertoad kibertoad merged commit a109a80 into tgriesser:master Mar 3, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 85.194%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.