Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size parameter to integer method #3074

Merged
merged 3 commits into from Mar 4, 2019

Conversation

Projects
None yet
2 participants
@iamchathu
Copy link
Contributor

iamchathu commented Feb 28, 2019

Size parameter work when we pass it. But it's not in definition.

Add size parameter to integer method
Size parameter work when we pass it. But it's not in definition.
@@ -552,7 +552,7 @@ declare namespace Knex {
dropColumn(columnName: string): TableBuilder;
dropColumns(...columnNames: string[]): TableBuilder;
renameColumn(from: string, to: string): ColumnBuilder;
integer(columnName: string): ColumnBuilder;
integer(columnName: string, size: number): ColumnBuilder;

This comment has been minimized.

Copy link
@kibertoad

kibertoad Mar 3, 2019

Collaborator

I'm curious which database you are using. Knex seems to accept this values for MSSQL and Oracle, but I can't find anywhere in their documentation that they support it. Not sure what would be the accurate name here, if there is anything in their documentation - we should use that name, but Knex itself calls it "length", not "size". In MySQL world it is "display width", but that is very MySQL-specific.

This comment has been minimized.

Copy link
@iamchathu

iamchathu Mar 4, 2019

Author Contributor

I'm using MySQL. I will update the parameter to length.

iamchathu and others added some commits Mar 4, 2019

Update knex.d.ts
Fix typo

@kibertoad kibertoad merged commit cfcb55d into tgriesser:master Mar 4, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@iamchathu iamchathu deleted the iamchathu:patch-1 branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.