Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include 'string' as accepted Knex constructor type definition #3105

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
2 participants
@enapupe
Copy link
Contributor

enapupe commented Mar 12, 2019

Hopefully I got it right this time!

Allowing Knex() to accept string type as it does accept string configuration parameter: https://github.com/tgriesser/knex/blob/master/src/knex.js#L12

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Mar 12, 2019

Beautiful. Thank you!

@kibertoad kibertoad merged commit de1c934 into tgriesser:master Mar 12, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 85.298%
Details
@enapupe

This comment has been minimized.

Copy link
Contributor Author

enapupe commented Mar 12, 2019

Thanks for being so responsive!

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Mar 12, 2019

haha, np!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.