New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Promise module for use in knex.destroy() #314

Merged
merged 1 commit into from Jun 12, 2014

Conversation

Projects
None yet
2 participants
@bmac
Contributor

bmac commented Jun 12, 2014

Currently calling knex.destroy() results in an error:

[ReferenceError: Promise is not defined]

@tgriesser I don't see a good place to put a test for knex.destroy any thoughts on where that should go?

@tgriesser

This comment has been minimized.

Owner

tgriesser commented Jun 12, 2014

Ah good catch, maybe just adding one right here after all the other integration tests have run?

@tgriesser tgriesser added the bug label Jun 12, 2014

@tgriesser

This comment has been minimized.

Owner

tgriesser commented Jun 12, 2014

I can add one in a bit.

@tgriesser tgriesser closed this Jun 12, 2014

@tgriesser tgriesser reopened this Jun 12, 2014

tgriesser added a commit that referenced this pull request Jun 12, 2014

Merge pull request #314 from bmac/destroy-error
Require Promise module for use in knex.destroy()

@tgriesser tgriesser merged commit b48ee2b into tgriesser:master Jun 12, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@tgriesser tgriesser added the fixed label Jun 12, 2014

tgriesser added a commit that referenced this pull request Jun 12, 2014

tgriesser added a commit that referenced this pull request Jun 12, 2014

elliotf pushed a commit to elliotf/knex that referenced this pull request Nov 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment