Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clearHaving function. #3141

Merged
merged 2 commits into from May 12, 2019

Conversation

Projects
None yet
2 participants
@dmamills
Copy link
Contributor

commented Apr 12, 2019

Based on #3128.

This PR adds a clearHaving function to the query builder, as well as a matching test case.
Also clarifies some existing comments.

@dmamills dmamills force-pushed the dmamills:feature/clearhaving branch from 76c09d5 to 0f1b774 Apr 12, 2019

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Apr 28, 2019

@dmamills Could you please add documentation (https://github.com/knex/documentation) and TS typings for this change?

@dmamills

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

@kibertoad no problem! see here for the matching documentation pr. I've also pushed another commit for the typescript definition.

Let me know if I missed anything!

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented May 11, 2019

@dmamills OK, I'm ready to merge this; could you please resolve conflicts? Sorry for the delay.

@dmamills dmamills force-pushed the dmamills:feature/clearhaving branch from 36034bf to 5cb95bb May 12, 2019

@dmamills dmamills force-pushed the dmamills:feature/clearhaving branch from 5cb95bb to dd8d3d4 May 12, 2019

@dmamills

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2019

@kibertoad all good now! You'll be able to close #3128 as well :)

@kibertoad kibertoad merged commit 617d36e into tgriesser:master May 12, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 85.236%
Details
@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented May 12, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.