Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pgsql specific table builder method typings #3146

Merged
merged 1 commit into from Jun 19, 2019

Conversation

Projects
None yet
2 participants
@davidspiess
Copy link
Contributor

commented Apr 15, 2019

I created PostgreSqlTableBuilder and PostgreSqlAlterTableBuilder interfaces, similar to the existing MySQL counterparts MySqlTableBuilder and MySqlAlterTableBuilder.

They include the currently missing inherits() method.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jun 18, 2019

@davidspiess Thank you for your contribution! Sorry it took so long to review it, somehow it slipped through the cracks. Could you please resolve conflicts?

@davidspiess

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

@kibertoad no worries! I rebased my commit on the latest master.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jun 19, 2019

Thanks!

@kibertoad kibertoad merged commit f70b726 into tgriesser:master Jun 19, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.185%
Details

@davidspiess davidspiess deleted the davidspiess:pgsql-table-builder-typings branch Jun 19, 2019

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jun 19, 2019

Released in 0.18.0-next2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.