Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add up for migrations #3205

Merged
merged 6 commits into from May 19, 2019

Conversation

Projects
None yet
3 participants
@leeallen337
Copy link
Contributor

commented May 16, 2019

This pull request attempts to add a new feature requested in #666 and briefly in #352

The feature is adding a migrate:up functionality which would only migrate the next migration that has not been run yet to the Migrator API and the CLI

Documentation PR: knex/documentation#194

Some other features that have been requested are a migrate:down and also being able to migrate up and migrate down to a specific version noted #1550, #352. I've started on these but don't want to put too much into one pull request

@leeallen337 leeallen337 marked this pull request as ready for review May 16, 2019

@elhigu

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

tests seem to be failing because node 12 doesn't run oracledb tests and it still checks coverage... I'll fix travis to run coverage only on oldest node version

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

@elhigu Oldest version is node 6 and that skips some tests. I would suggest latest LTS instead.

@elhigu

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

I meant node oldes LTS so node 8, we cant know if latest will have always all drivers ready.

@elhigu

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

now lets hope it works #3207

@kibertoad kibertoad merged commit 08478f2 into tgriesser:master May 19, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage decreased (-0.06%) to 88.748%
Details
@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented May 19, 2019

Thanks!

@leeallen337 leeallen337 deleted the leeallen337:feature/add-up-for-migrations branch May 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.