Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with typings of joins and some conflicts with Bluebird #3209

Merged
merged 1 commit into from May 19, 2019

Conversation

Projects
None yet
2 participants
@lorefnon
Copy link
Contributor

commented May 18, 2019

  • Joins would result in previous result type to not be propagated through the fluent chain in non-inferrable scenarios. This fixes #3168 (comment).

  • Removed unnecessary generics from with* functions and added tests.

  • Fixed incompatibility with esModuleInterop: true. Bluebird typings use export = and thus we need to be import through import = to be compatible to both modes. This fixes #3168 (comment) and #3210

@lorefnon lorefnon force-pushed the lorefnon:type-incompatibility branch 2 times, most recently from e85a3de to 36f09e2 May 18, 2019

@lorefnon lorefnon force-pushed the lorefnon:type-incompatibility branch from 36f09e2 to 92f8070 May 19, 2019

@kibertoad kibertoad merged commit 3b3fdf4 into tgriesser:master May 19, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.714%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.