Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support type-safe aliasing through refs #3215

Merged
merged 1 commit into from May 22, 2019

Conversation

Projects
None yet
4 participants
@lorefnon
Copy link
Contributor

commented May 22, 2019

No description provided.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

Looks great! Restarted failed job, I'm pretty sure that's just a flaky test.

@kibertoad kibertoad merged commit 92cb805 into tgriesser:master May 22, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.652%
Details
@elhigu

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

@kibertoad do you remember which test failed (flaky tests should be flagged and removed from testbench or to be fixed)? I couldn't locate that build from travis.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

@elhigu One of the Oracle ones, but don't remember specific one. Will definitely write it down next time.

@jpike88

This comment has been minimized.

Copy link

commented May 26, 2019

this is causing type errors everywhere... is there an eta on next release?

@lorefnon

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

Can you please share some examples of errors that you are receiving ? Are these with last stable release or with @next ?

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented May 27, 2019

@jpike88 Could you please try if knex@0.17.0-next6 is working correctly for you in this regard? If no, we'd like to fix it before releasing final 0.17.0.

@jpike88

This comment has been minimized.

Copy link

commented May 27, 2019

knex@0.17.0-next6 has fixed it, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.