Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Knex.Config types to include log #3221

Merged
merged 1 commit into from May 26, 2019

Conversation

Projects
None yet
3 participants
@lorefnon
Copy link
Contributor

commented May 25, 2019

Fixes #3148

Show resolved Hide resolved types/index.d.ts Outdated

@lorefnon lorefnon force-pushed the lorefnon:#3148 branch from 3dfd08a to 3ec7ed5 May 25, 2019

@lorefnon

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

On a somewhat unrelated note, what is the ideal place (in documentation) to add notes about typescript usage ? Can it be a part of the primary documentation site or a separate page somewhere ?

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented May 25, 2019

Good question! We don't have well-defined place yet. What do you think makes most sense? We could use a new section on a website documentation for sure.

@lorefnon

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

Similar to SQL dialect dropdown, should we have a language dropdown with javascript (default) & typescript ? Selecting typescript in the dropdown shows ts specifics notes alongside the docs for individual functions.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented May 25, 2019

Great idea!

@kibertoad kibertoad merged commit fb91f65 into tgriesser:master May 26, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.652%
Details
@elhigu

This comment has been minimized.

Copy link
Collaborator

commented May 27, 2019

I think, if there is need to have typescript docs, they can be shown in the same page. Those should be helpful also for people using plain javascript. Actually all dialect specific notes are also in the same page, dialect dropdown only selects type output of generated queries inside documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.