Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node.js 6. Remove babel. #3227

Merged
merged 4 commits into from Jun 3, 2019

Conversation

Projects
None yet
2 participants
@kibertoad
Copy link
Collaborator

commented May 28, 2019

No description provided.

@kibertoad kibertoad requested review from elhigu and wubzz May 28, 2019

kibertoad added some commits May 28, 2019

Merge branches 'general/drop-node-6' and 'master' of https://github.c…
…om/tgriesser/knex into general/drop-node-6

# Conflicts:
#	package.json
@elhigu

elhigu approved these changes Jun 3, 2019

Copy link
Collaborator

left a comment

All did seem just mechanical changes. I suppose everything is good here because tests are passing just fine and looks like the coverage is also still calculated just fine from tests.

@kibertoad kibertoad merged commit c431ffc into master Jun 3, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on general/drop-node-6 at 87.935%
Details

@kibertoad kibertoad deleted the general/drop-node-6 branch Jun 3, 2019

kibertoad added a commit that referenced this pull request Jun 26, 2019

Fix comments that were modified by find & replace (#3308)
The find & replace of ES module import syntax to cjs `require`s in #3227 modified some comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.