Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migrate:down functionality #3228

Merged

Conversation

Projects
None yet
2 participants
@leeallen337
Copy link
Contributor

commented May 29, 2019

This pull request attemps to add a new feature requested in #666 and briefly in #352

The feature is adding a migrate:down functionality which would rollback only the last run migration to the Migrator API and the CLI

Documentation PR: knex/documentation#197

@leeallen337 leeallen337 marked this pull request as ready for review May 29, 2019

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented May 29, 2019

Thanks!

@kibertoad kibertoad merged commit 1fe5ee0 into tgriesser:master May 29, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.05%) to 88.617%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented May 29, 2019

@leeallen337 Do you use Node 8+? Next major release 0.18 is going to drop Node 6 support, so if you need it on an older node, would make sense to merge this PR to branch 0.17.

@leeallen337

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

@kibertoad I do use Node 8+. Maybe it should get merged into 0.17? I saw that migrate:up made it into 0.16 so it might be beneficial for users still on Node 6 to have migrate:down in addition to migrate:up?

I went ahead and created a pull request for it since I'm about to leave for work and won't be available until later

#3232

@leeallen337 leeallen337 deleted the leeallen337:feature/add-down-for-migrations branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.