Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Do not reject promise on transaction rollback #3235
referenced this pull request
Jun 3, 2019
Sounds like a good idea! I didn’t see any problems with code either.
I should write out some tests which actually tests what happens in knex In different dialects when query throws e.g. conflict error inside transaction which is not leaked out of handler and not causing knex side rollback. Currently I know only more or less what pg dialect does in that case.