Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extension from knexfile filename for generating migrations unless overriden #3282

Merged
merged 1 commit into from Jun 14, 2019

Conversation

Projects
None yet
2 participants
@kibertoad
Copy link
Collaborator

commented Jun 13, 2019

fixes #3003

@kibertoad kibertoad changed the title Use extension from knexfile for generating migrations unless overriden Use extension from knexfile path for generating migrations unless overriden Jun 13, 2019

@kibertoad kibertoad changed the title Use extension from knexfile path for generating migrations unless overriden Use extension from knexfile filenamefor generating migrations unless overriden Jun 13, 2019

@kibertoad kibertoad changed the title Use extension from knexfile filenamefor generating migrations unless overriden Use extension from knexfile filename for generating migrations unless overriden Jun 13, 2019

@dgadelha

This comment has been minimized.

Copy link

commented Jun 13, 2019

It works for me, is it possible to release this?

@kibertoad

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 14, 2019

@dgadelha 0.18.0 is not yet ready, would next-1 work for you? Also master is not transpiled anymore, so you can directly depend on branches and commits.

@dgadelha

This comment has been minimized.

Copy link

commented Jun 14, 2019

It would, can we depend a commit directly from npm? Thought you had to publish it there.

@kibertoad

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 14, 2019

@kibertoad kibertoad merged commit 04b12f2 into master Jun 14, 2019

2 of 3 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 88.172%
Details

@kibertoad kibertoad deleted the 3003-resolve-extension-from-knexfile branch Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.