Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix empty --version output #3312

Merged
merged 2 commits into from Jun 30, 2019

Conversation

Projects
None yet
2 participants
@Saka7
Copy link
Contributor

commented Jun 27, 2019

Currently, --version/-V output looks broken (empty output):

knex --version

Knex CLI version: 
Local Knex version: 

#3311

@Saka7 Saka7 referenced this pull request Jun 27, 2019

Closed

CLI version output is empty #3311

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jun 27, 2019

Thank you! Could you please add test for this? Look at https://github.com/tgriesser/knex/tree/master/test/cli for inspiration.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jun 30, 2019

@Saka7 Please let me know if you'll need any help with writing a test!

@Saka7 Saka7 force-pushed the Saka7:fix/version-output branch from cff02ef to 6880adc Jun 30, 2019

@Saka7

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2019

@kibertoad I've added a test for cli version, please check

@kibertoad kibertoad merged commit 0a85331 into tgriesser:master Jun 30, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 88.067%
Details
@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jun 30, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.