Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI/add stub option #3316

Merged
merged 7 commits into from Jul 4, 2019

Conversation

Projects
None yet
2 participants
@the-vampiire
Copy link
Contributor

commented Jun 28, 2019

closes #3219

adds --stub option to migration:make CLI command

usage

  • --stub <name> looks for stub file by name in config.migrations.directory
  • --stub </file/path> looks for stub file by path relative to knexfile.*

the-vampiire added some commits Jun 28, 2019

CLI: add --stub option to migration:make
**usage**
-`--stub <name>` looks for stub file by name in `config.migrations.directory`
- `--stub </file/path>` looks for stub file by path relative to `knexfile.*`
CLI: migrate-make.spec tests for --stub option
- add utilities for testing the --stub option
- add success and failure tests for --stub option
Show resolved Hide resolved bin/cli.js Outdated
Show resolved Hide resolved bin/cli.js Outdated

the-vampiire added some commits Jul 1, 2019

CLI: moved utility functions to /utils (read below):
- moving the 2 utils getMigrationsExtensions, getStubPath had dependencies
- the depended utils had to be moved over as well and their libs imported
- utils moved: exit, success, resolveEnvironmentConfig, checkLocalModule
CLI tests utils: bumped cli-testlab, ref migrationMatchesStub
- bumped cli-testlab to 1.7.0
- now using new fileHelper glob reader

function getStubPath(env, opts) {
const config = resolveEnvironmentConfig(opts, env.configuration);
const stubDirectory = config.migrations && config.migrations.directory;

This comment has been minimized.

Copy link
@the-vampiire

the-vampiire Jul 1, 2019

Author Contributor

this could be moved down. doesnt need to be assigned unless func reaches line 133

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jul 4, 2019

Thanks!

@kibertoad kibertoad merged commit 2b63332 into tgriesser:master Jul 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on cli/add-stub-option at 88.215%
Details
@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jul 4, 2019

Released in 0.18.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.