Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Respect the knexfile stub option while generating a migration #3337

Merged
merged 3 commits into from Jul 10, 2019

Conversation

Projects
None yet
2 participants
@bohdan-shulha
Copy link
Contributor

commented Jul 7, 2019

fixes #3333

@bohdan-shulha bohdan-shulha force-pushed the bohdan-shulha:patch-1 branch from 0096b5c to 579e3b4 Jul 7, 2019

@bohdan-shulha bohdan-shulha force-pushed the bohdan-shulha:patch-1 branch from 579e3b4 to 59cd34d Jul 7, 2019

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jul 7, 2019

Thanks! Could you please add test in https://github.com/tgriesser/knex/blob/master/test/cli/migrate-make.spec.js for this case?

@kibertoad kibertoad merged commit c6481e8 into tgriesser:master Jul 10, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 88.249%
Details
@bohdan-shulha

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

@kibertoad , thanks for the tests and the release, I had no time this week to implement test cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.