Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor enhancements around aliasing of aggregates #3354

Merged
merged 1 commit into from Jul 16, 2019

Conversation

@lorefnon
Copy link
Contributor

commented Jul 16, 2019

  • Allows an options object to specify alias (as suggested in #3315 (comment)) (Closes #3315)
  • Allows multiple aliases when using object syntax (Closes #2871)

@lorefnon lorefnon force-pushed the lorefnon:aggr-enh branch 2 times, most recently from 8cc36b5 to 200a13b Jul 16, 2019

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jul 16, 2019

One test is failing on mssql.

@lorefnon lorefnon force-pushed the lorefnon:aggr-enh branch from 200a13b to edcf177 Jul 16, 2019

Minor enhancements around aliasing of aggregates
- Allows an options object to specify alias (as suggested in #3315 (comment)) (Closes #3315)
- Allows multiple aliases when using object syntax (Closes #2871)

@lorefnon lorefnon force-pushed the lorefnon:aggr-enh branch from edcf177 to 7b30cb6 Jul 16, 2019

@lorefnon

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

@kibertoad this has now been addressed.

@kibertoad kibertoad merged commit 3e1a5ee into tgriesser:master Jul 16, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.05%) to 88.182%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jul 16, 2019

I assume this also needsdocumentation update?

@elhigu elhigu referenced this pull request Jul 16, 2019
@elhigu

This comment has been minimized.

Copy link
Collaborator

commented Jul 16, 2019

Added issue for it.

@lorefnon

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

Yes, I'll take care of that.

lorefnon added a commit to lorefnon/knex-docs that referenced this pull request Jul 17, 2019

lorefnon added a commit to knex/documentation that referenced this pull request Jul 17, 2019

lorefnon added a commit to knex/documentation that referenced this pull request Jul 17, 2019

kibertoad added a commit to knex/documentation that referenced this pull request Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.