Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent handling of nested transactions #3393

Merged
merged 5 commits into from Aug 16, 2019

Conversation

@kibertoad
Copy link
Collaborator

commented Aug 13, 2019

fixes #3389 #3320

@kibertoad kibertoad requested a review from elhigu Aug 13, 2019

@@ -18,7 +17,7 @@ matrix:
env: TESTSCRIPT=test:nyc DB="oracledb mssql mysql mysql2 postgres sqlite3" KNEX_TEST_TIMEOUT=60000
install:
- npm i
- (echo $DB | grep oracledb) && npm install oracledb || true
- (echo $DB | grep oracledb) && npm install oracledb@3.1.2 || true

This comment has been minimized.

Copy link
@kibertoad

kibertoad Aug 14, 2019

Author Collaborator

See #3396 for the reason of this change.

@kibertoad kibertoad referenced this pull request Aug 14, 2019
4 of 4 tasks complete
Igor Savin added 2 commits Aug 16, 2019

@kibertoad kibertoad merged commit 871dadb into master Aug 16, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on improvement/3389-nested-trxs at 88.225%
Details

@kibertoad kibertoad deleted the improvement/3389-nested-trxs branch Aug 16, 2019

@elhigu

This comment has been minimized.

Copy link
Collaborator

commented Aug 16, 2019

Is there need to add more info about nested transactions and how rejections are happening to documentation?

@kibertoad

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 16, 2019

@elhigu I'll review it just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.