Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make transaction rejection consistent across dialects #3399

Merged
merged 1 commit into from Aug 17, 2019

Conversation

@thetutlage
Copy link
Contributor

commented Aug 16, 2019

Making mysql and mysql2 dialects use the same sql check as the base transaction class.

sql.toUpperCase() === 'ROLLBACK' &&
t.doNotRejectOnRollback
) {
if (t.doNotRejectOnRollback && /^ROLLBACK\b/i.test(sql)) {

This comment has been minimized.

Copy link
@kibertoad

kibertoad Aug 16, 2019

Collaborator

What happens if sql is nil here? It just resolves to false or throw an error?

This comment has been minimized.

Copy link
@thetutlage

thetutlage Aug 17, 2019

Author Contributor

Returns false

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Aug 16, 2019

You can pull latest changes from master to resolve oracle test failures.

@thetutlage thetutlage force-pushed the thetutlage:fix/transactions branch from f3e6616 to 181402c Aug 17, 2019

@kibertoad kibertoad merged commit 831b9bc into tgriesser:master Aug 17, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.225%
Details
@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Aug 17, 2019

Thanks! I'll try to publish new release tonight.

@thetutlage

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2019

Wow, thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.