Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all supported Mysql2 dialect options #980

Merged
merged 1 commit into from Feb 5, 2016

Conversation

Projects
None yet
2 participants
@jtwebman
Copy link
Contributor

jtwebman commented Sep 17, 2015

You are missing a bunch of support options and one that is coming soon to make decimals numbers. I added them all though I am not sure why we filter them at all. We should just pass them along but didn't want to make a breaking change like that.

Had to remove charset as it is different then the Pool2 library's charset.

@jtwebman

This comment has been minimized.

Copy link
Contributor Author

jtwebman commented Sep 17, 2015

@rhys-vdw Can we get this in the next release? Let me know if I am missing anything.

@jtwebman

This comment has been minimized.

Copy link
Contributor Author

jtwebman commented Sep 17, 2015

FYI, we are running this in production now off my fork and branch.

@jtwebman

This comment has been minimized.

Copy link
Contributor Author

jtwebman commented Jan 19, 2016

@rhys-vdw @Grimace1975 @elhigu @tgriesser This PR is a few months old so I went ahead and rebased off master. Let me know if I need to change anything as this is my first commit to this project.

@jtwebman

This comment has been minimized.

Copy link
Contributor Author

jtwebman commented Feb 5, 2016

I cleaned this up again and rebased off master to make it easy to merge in.

elhigu added a commit that referenced this pull request Feb 5, 2016

Merge pull request #980 from jtwebman/add_mysql2_options
Add all supported Mysql2 dialect options

@elhigu elhigu merged commit c2b7793 into tgriesser:master Feb 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.