Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic/manual repository cleanup job #1016

Closed
Cyberboss opened this issue May 24, 2020 · 5 comments · Fixed by #1855
Closed

Automatic/manual repository cleanup job #1016

Cyberboss opened this issue May 24, 2020 · 5 comments · Fixed by #1855
Assignees
@Cyberboss
Labels
Area: Repository With regard to managing the git repository Feature Request Requested functionality HTTP API The JSON Web API that controls the server Work In Progress Issue being actively worked on
Milestone
v6.9.0

Comments

@Cyberboss
Copy link
Member

Libgit2 currently does not have this functionality. See libgit2/libgit2#3247

Workaround: Delete and reclone the repository.
@Cyberboss Cyberboss added Feature Request Requested functionality Backlog Issue to be scheduled for addressing HTTP API The JSON Web API that controls the server Upstream Issue Issue with BYOND, Nuget, or .NET dependency Area: Repository With regard to managing the git repository Migration Requires or performs a database migration labels May 24, 2020
@Cyberboss Cyberboss added this to the V4 Backlog milestone May 24, 2020
@Cyberboss Cyberboss removed the Backlog Issue to be scheduled for addressing label Jul 13, 2020
@Cyberboss
Copy link
Member Author

We can implement this by running git.exe gc in RepositoryManager

@Cyberboss Cyberboss added Backlog Issue to be scheduled for addressing and removed Upstream Issue Issue with BYOND, Nuget, or .NET dependency Migration Requires or performs a database migration labels Oct 9, 2022
@Cyberboss
Copy link
Member Author

We cant guarantee that's installed though

@Cyberboss Cyberboss added Upstream Issue Issue with BYOND, Nuget, or .NET dependency and removed Backlog Issue to be scheduled for addressing labels Apr 20, 2024
@Cyberboss
Copy link
Member Author

Not doing this unless LibGit2 decides to support it. Rather not have a dependency on git.exe

@Cyberboss Cyberboss modified the milestones: Backlog, v6.9.0 Jul 31, 2024
@Cyberboss Cyberboss added Migration Requires or performs a database migration Ready Issue ready to be addressed and removed Upstream Issue Issue with BYOND, Nuget, or .NET dependency labels Jul 31, 2024
@Cyberboss
Copy link
Member Author

Okay, we're just going to add a new repo reclone job.

@Cyberboss Cyberboss changed the title Automatic git gc support Automatic/manual repository cleanup job Jul 31, 2024
@Cyberboss
Copy link
Member Author

Cyberboss commented Jul 31, 2024 •
edited
Loading

Remember to delete all test merge/revinfo data for the instance

@Cyberboss Cyberboss added Work In Progress Issue being actively worked on and removed Ready Issue ready to be addressed Migration Requires or performs a database migration labels Aug 11, 2024
@Cyberboss Cyberboss self-assigned this Aug 11, 2024
Cyberboss added a commit that referenced this issue Aug 11, 2024
@Cyberboss
Implement repository recloning
f2599d3 
Closes #1016
Cyberboss added a commit that referenced this issue Aug 11, 2024
@Cyberboss
Implement repository recloning
808ce06 
Closes #1016
@Cyberboss Cyberboss mentioned this issue Aug 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cyberboss Cyberboss

Labels
Area: Repository With regard to managing the git repository Feature Request Requested functionality HTTP API The JSON Web API that controls the server Work In Progress Issue being actively worked on
Projects
None yet
Milestone
v6.9.0
Development

Successfully merging a pull request may close this issue.

Autismo Feature Saturday tgstation/tgstation-server
1 participant
@Cyberboss