Skip to content

Fix potentially sending DMAPI messages to the wrong channels after a TGS restart #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
May 24, 2023

Conversation

Cyberboss
Copy link
Member

@Cyberboss Cyberboss commented May 20, 2023

🆑
Fixed initial chat channel update not getting sent to the DMAPI after a TGS restart.
Removed the possibility for chat bot connections to slow down watchdog processing upon starting or restarting TGS.
Fixed chat bot disconnection errors being able to generate 500 responses.
Fixed a non-fatal error registering as a 500 error when updating or restarting.
Fixed race conditions related to updating deployment chat messages.
Fixed a memory leak when chat bots are deleted or disabled via the API.
Fixed a race condition relating to sending the initial watchdog chat message on instance auto-start or reattach.
/:cl:

🆑 DreamMaker API
The cache of chat channels will now be purged if the DMAPI detects a TGS detach.
🆑

Fixes #1490

Merge with [DMDeploy][TGSDeploy]

@Cyberboss Cyberboss added Fix Fixes incorrect functionality Area: DMAPI Communication between TGS and DM Area: Chat With regard to managing chat bots Area: Watchdog With regard to managing DreamDaemon servers Component Issue Issue regarding the service components labels May 20, 2023
@Cyberboss Cyberboss added this to the v5.12.2 milestone May 20, 2023
@Cyberboss Cyberboss enabled auto-merge May 20, 2023 23:47
github-actions[bot]
github-actions bot previously approved these changes May 20, 2023
github-actions[bot]
github-actions bot previously approved these changes May 21, 2023
@Cyberboss Cyberboss added Priority: CRITICAL Alarm clock up. Fix immediately Security Issue pertaining to Authentication/Authorization or NTC (Never Trust the Client) labels May 21, 2023
@Cyberboss Cyberboss closed this May 21, 2023
auto-merge was automatically disabled May 21, 2023 05:42

Pull request was closed

@Cyberboss Cyberboss reopened this May 21, 2023
github-actions[bot]
github-actions bot previously approved these changes May 21, 2023
github-actions[bot]
github-actions bot previously approved these changes May 23, 2023
@Cyberboss Cyberboss added CI/CD IT'S NOT A PHASE MOM, IT'S A REAL SPECIALIZATION Regression Test We've seen this before, make sure it doesn't happen again labels May 23, 2023
github-actions[bot]
github-actions bot previously approved these changes May 23, 2023
@Cyberboss Cyberboss disabled auto-merge May 23, 2023 12:06
@Cyberboss Cyberboss enabled auto-merge May 23, 2023 12:06
@Cyberboss
Copy link
Member Author

Yes, future me. [DMDeploy][TGSDeploy] is on the commit.

github-actions[bot]
github-actions bot previously approved these changes May 23, 2023
github-actions[bot]
github-actions bot previously approved these changes May 23, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #1493 (86f20a0) into master (294bbf8) will decrease coverage by 1.99%.
The diff coverage is 62.08%.

@@            Coverage Diff             @@
##           master    #1493      +/-   ##
==========================================
- Coverage   74.24%   72.25%   -1.99%     
==========================================
  Files         355      355              
  Lines       21576    21647      +71     
==========================================
- Hits        16020    15642     -378     
- Misses       5556     6005     +449     

@Cyberboss Cyberboss merged commit 7aa47f7 into master May 24, 2023
@Cyberboss Cyberboss deleted the 1490-FixChatReattach branch May 24, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Chat With regard to managing chat bots Area: DMAPI Communication between TGS and DM Area: Watchdog With regard to managing DreamDaemon servers CI/CD IT'S NOT A PHASE MOM, IT'S A REAL SPECIALIZATION Component Issue Issue regarding the service components Fix Fixes incorrect functionality Priority: CRITICAL Alarm clock up. Fix immediately Regression Test We've seen this before, make sure it doesn't happen again
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instances needs to update chat tracking contexts after restarting and reattaching
2 participants