-
-
Notifications
You must be signed in to change notification settings - Fork 86
Fix potentially sending DMAPI messages to the wrong channels after a TGS restart #1493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, future me. |
265ad5c to
6734ab6
Compare
6734ab6 to
4cd7d57
Compare
Codecov Report
@@ Coverage Diff @@
## master #1493 +/- ##
==========================================
- Coverage 74.24% 72.25% -1.99%
==========================================
Files 355 355
Lines 21576 21647 +71
==========================================
- Hits 16020 15642 -378
- Misses 5556 6005 +449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Chat
With regard to managing chat bots
Area: DMAPI
Communication between TGS and DM
Area: Watchdog
With regard to managing DreamDaemon servers
CI/CD
IT'S NOT A PHASE MOM, IT'S A REAL SPECIALIZATION
Component Issue
Issue regarding the service components
Fix
Fixes incorrect functionality
Priority: CRITICAL
Alarm clock up. Fix immediately
Regression Test
We've seen this before, make sure it doesn't happen again
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆑
Fixed initial chat channel update not getting sent to the DMAPI after a TGS restart.
Removed the possibility for chat bot connections to slow down watchdog processing upon starting or restarting TGS.
Fixed chat bot disconnection errors being able to generate 500 responses.
Fixed a non-fatal error registering as a 500 error when updating or restarting.
Fixed race conditions related to updating deployment chat messages.
Fixed a memory leak when chat bots are deleted or disabled via the API.
Fixed a race condition relating to sending the initial watchdog chat message on instance auto-start or reattach.
/:cl:
🆑 DreamMaker API
The cache of chat channels will now be purged if the DMAPI detects a TGS detach.
🆑
Fixes #1490
Merge with
[DMDeploy][TGSDeploy]