AI Photography #1357
AI Photography #1357
Conversation
…tion into AIphotography
|
Still new to Git. How do I test this without mucking up my /tg/ Repo? |
|
Here's a direct download https://github.com/AndroidSFV/-tg-station/archive/AIphotography.zip Alternatively just pull from his repo |
|
@AndroidSFV The photo issues are documented and explained in an existing issue report(s)- Baystation12/Baystation12#2725 There's no good way to fix them, that I know of, but you're welcome to look into it. Might be worth asking about it on the byond forums. |
|
@GunHog you can easily test pull requests with https://gist.github.com/Giacomand/bbe7c557d329fdb680c4 |
|
I modded the file as instructed...but I do not know what "fetch from the upstream for your repo" means. You do not need to bother holding my hand through this, I will just...try stuff until something happens. Thanks for the link though, it is quite useful to someone who knows how to use GitHub properly. |
|
Upstream is the internet repository which you originally cloned from, but you can change that if you want. Fetching is a way of getting the updates, but not putting them into your branch (the commits are stored in a special branch called FETCH_HEAD). Basically you just want to update your local branch with -tg-station:master |
| @@ -218,13 +248,79 @@ | |||
| P.icon = ic | |||
| P.img = temp | |||
| P.desc = mobs | |||
| P.pixel_x = rand(-10, 10) | |||
| P.pixel_y = rand(-10, 10) | |||
| // P.pixel_x = rand(-10, 10) | |||
There was a problem hiding this comment.
IIRC This makes it so when photos are printed they're offset randomly on the tile, so they're not hidden underneath each other.
It'd be better to leave it in
There was a problem hiding this comment.
Yup, that's what they do. Uncomment these please!
|
This sounds like an unbelievably wonderful thing, thank you for this. |
…on#1357) * Adds feedback when successfully emaging a generator (tgstation#62524) * Adds a span_notice when emaging a PACMAN * Adds feedback when successfully emaging a generator. * Adds feedback when successfully emaging a generator Co-authored-by: Stonetear <89315023+Stonetear@users.noreply.github.com>
Gives the AI two verbs, Take Picture and View Picture. The AI can also print these pictures at a photocopier if there is enough toner, and on a newscaster. The AI is given an ai_camera in New(). The picture is taken centered on the AI's eyeobj. I broke up some of the original photography code so that it could be used with the AI camera.
Added some checks to photocopier.dm that when the AI tried to eject a photo from a photocopier, it would end up in the AI's hand. Also increased the amount of toner a photocopier holds (and how much a toner cartridge adds) to 40. I also gave a toggle option for non-ai mobs to copy in greyscale or color.
Consolidated some datacore code into datacore.dm.
To come in future pulls: A way for AI's to delete pictures they don't like so it isn't cluttered, targeting of the center of the picture based on a mouse click, giving this functionality to borgs, unifying picture storage/viewing among all silicons, making the selection interface into some form a window with html interaction.
Please offer any feedback or criticism in a detailed manner so I can address it properly.
Notes: code/datums/obj.dm and /code/defines/obj.dm, where I found those bits of datacore code, do not really serve a purpose and should have their contents shifted into more appropriate .dm's. Also, when you try to take a picture of the kitchen, the kitchen turfs appear black in the picture. I will open issues for both.
Also, a big thanks to Nodrak and Giacom for providing invaluable advice and assistance.