Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables Frankensteins #17623

Merged
merged 1 commit into from May 21, 2016
Merged

Conversation

RemieRichards
Copy link
Contributor

@RemieRichards RemieRichards commented May 12, 2016

  • Allows you to frankenstein organic limbs onto people, dealing 10 tox damage if the species match
  • Allows you to frankenstein organic limbs from OTHER SPECIES onto people, dealing 30 tox damage
  • Fixes a bug where /body_parts used for surgery would stay in your hands when they're supposed to be in nullspace.

I say "Enabled" and not "Added" as this is clearly part of the system, Phil just hasn't enabled it because it's not 100% finished (I only really noticed species parts like snouts not following their limbs but that's only a minor graphical issue) but I've enabled it anyway as it's p.fun regardless

@phil235 if you want to save this for when it's more functional feel free to close it.

ART

…different species!), dealing an appropriate amount of tox damage
@RemieRichards RemieRichards added the Feature Exposes new bugs in interesting ways label May 12, 2016
@PKPenguin321
Copy link
Contributor

fun times ahead friend
limbs should probably expire and not work for this after a while though, kinda like defibbed corpses

@Ryll-Ryll
Copy link
Contributor

good shit good shit, if limbs are made to expire they should probably halt that while in a freezer though

@@ -43,6 +45,10 @@
qdel(tool)
else
L = tool
user.drop_item()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, my bad

@phil235
Copy link
Contributor

phil235 commented May 13, 2016

I'm okay with this.
Maybe the name of the surgery needs to be updated though.

@drynwyn
Copy link
Contributor

drynwyn commented May 13, 2016

How do plasmeme limbs work with this? Will someone with a plasmeme arm frankensteined onto them catch fire in a non-plasma environment?

@phil235
Copy link
Contributor

phil235 commented May 13, 2016

@drynwyn nope

@imtakingabreakdontatme
Copy link
Contributor

This seems fun as a MAD SCIENCE thing but I'm worried that will never be done, and instead people will just slap their limbs back on after a bomb

@Fox-McCloud
Copy link
Contributor

Fox-McCloud commented May 13, 2016

@KorPhaeron

That's exactly what happens on Para, but I don't think that's necessarily a bad thing. Do note, though, that organs and limbs DO rot when they're outside of the body though (reversible with a chem).

Side note: perhaps hands and feet should be brought back, at some point? shrug

@PKPenguin321
Copy link
Contributor

This seems fun as a MAD SCIENCE thing but I'm worried that will never be done, and instead people will just slap their limbs back on after a bomb

this was my reasoning for suggesting limb expiration

@imtakingabreakdontatme
Copy link
Contributor

@RemieRichards

Would it be too much trouble to require some madscience serum that you had to use on the limb to enable attachment?

@RemieRichards
Copy link
Contributor Author

I figured the guaranteed tox damage (10 if it's your species, 30 if it's not) was enough of a factor.
I could double these values?

@imtakingabreakdontatme
Copy link
Contributor

I guess that'd be better, but it'd still cut medbay/robotics out of the loop (security, or anyone for that matter, could just slap their limb back on in the execution room/holodeck followed by drinking a bit of tea)

@RemieRichards
Copy link
Contributor Author

Does the damaged limb not retain it's damage? if so that would be a good way to say "Hey, don't use the limb you just lost in an explosion, it's fucked"

@drynwyn
Copy link
Contributor

drynwyn commented May 14, 2016

Require an application of Strange Reagent before the limb functions, maybe? You can sew it on but it's dead and doesn't work until you revive it with !!SCIENCE JUICE!!

@imtakingabreakdontatme
Copy link
Contributor

@RemieRichards

I could be wrong, but I think that explosions just drop_limb without doing any damage to it.

Also I'm not sure if damage is retained by the limb at all in any case

@imtakingabreakdontatme
Copy link
Contributor

@RemieRichards

If you want to make limb damage transfer when when it gets torn off (and make limbs that are too mangled unsuitable for surgery) that'd probably be better than my idea of a serum anyway.

@Core0verload
Copy link
Contributor

If you can just slap your torn off leg back on yourself, that's bad. It makes loss of limbs mean nothing. Make it something like surgery, and allow only lings to install limbs on the go.

@ghost
Copy link

ghost commented May 15, 2016

give limbs health so if you saw off a limb it isn't a good idea to reattach it without using a bruise pack

also using the tesla to bring your frankenstein to life when???

edit, actually at first I was against PK's idea but making freezers and fridges be more than a locker/crate reskin would be nice, the chef that leaves out his food should PAY THE PRICE, REEEEEEE

@optimumtact
Copy link
Member

@RemieRichards let me know if this is ready

@RemieRichards
Copy link
Contributor Author

Should be.

@optimumtact optimumtact merged commit 5a800f9 into tgstation:master May 21, 2016
@FantasticFwoosh
Copy link
Contributor

FantasticFwoosh commented Aug 10, 2017

  • This doesn't work anymore, its not persistent last time i checked for aesthetic visual changes carrying onto new bodies, except maybe in the case of humans to other humans of the same skin tone.

@optimumtact
Copy link
Member

Then file a bug report, don't comment on a year old PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants