Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
DCS Continued #29324
I hate git sometimes
This PR adds documentation and final touches missing from #29178
Datum Component System (DCS)
Loosely adapted from /vg/. This is an entity component system for adding behaviours to datums when inheritance doesn't quite cut it. By using signals and events instead of direct inheritance, you can inject behaviours without hacky overloads. It requires a different method of thinking, but is not hard to use correctly. If a behaviour can have application across more than one thing. Make it generic, make it a component. Atom/mob/obj event? Give it a signal, and forward it's arguments with a
In the code
At the time of this writing, every object that is slippery overrides atom/Crossed does some checks, then slips the mob. Instead of all those Crossed overrides they could add a slippery component to all these objects. And have the checks in one proc that is run by the Crossed event
A lot of objects have powercells. The
The radio object as it is should not exist, given that more things use the concept of radios rather than the object itself. The actual function of the radio can exist in a component which all the things that use it (Request consoles, actual radios, the SM shard) can add to themselves.
Stands have a lot of procs which mimic mob procs. Rather than inserting hooks for all these procs in overrides, the same can be accomplished with signals
See signals and their arguments in __DEFINES\components.dm
Actually, HOLY CRAB
Its not documentation I want @Iamgoofball, it's that the original PR did not describe what the pr did in the pr body.
Pretending this is a solution is part of the problem.
I want cyberboss to:
This isn't about the past, this is about the future, and the fact that @Cyberboss seems to think slapping some readme document in the repo is a adequate replacement for the basic requirement that you DETAIL WHAT THE FUCK YOUR PR IS tells me nothing has been learned, and this issue will come up in the future if nothing is done to change it.
Wait @MrStonedOne but I never apologized for naming the lighting PR "rebase to /vg/"…
On Jul 20, 2017 08:36, "d3athrow" ***@***.***> wrote: porting vg code How dare you — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29324 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHu1w8zQxyE1hj_vztJqAnr2CUV3Mbsiks5sPvWDgaJpZM4OaZxM> .
You still need to document this pr properly.
Something along the lines of
And I still want to see at least point 3 addressed. You've been scapegoating this entire thing, so I want to at least see you admit or acknowledge fault. even if it's just a simple