Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY]Humans now have hygiene (DOES NOT AFFECT MOOD GO AWAY MOODPOSTERS) #41986

Merged
merged 15 commits into from Jan 1, 2019

Conversation

@Qustinnus
Copy link
Member

commented Dec 16, 2018

馃啈 Floyd / Qustinnus
tweak: You now have to be naked to get the nice shower moodlet, if you shower with clothes you get a bad moodie
add: Hygiene, you slowly become dirty over time, the more covered in blood you are the faster you will lose hygiene. When you are too dirty you will have a stink overlay. (Hygiene doesn't affect mood currently) It also spawns miasma slowly if you smell like shit.
add: adds NEET and neat traits. NEET's get 20 bucks social welfare extra and like being unhygienic, while neat people dislike being unhygienic and like being hygienic
/馃啈

This doesn't affect mood so plssss dont strawman in this PR about how I'm forcing you to shower or die or whatever

This PR is mostly visual and will allow for people to judge others for literaly being smelly as hell.

also NEET and neat traits which interact with being smelly. (neat likes hygiene, dislikes lack of it. NEETs like lack of hygiene and get some social welfare (20 bucks))

https://streamable.com/cz8x6

I might get a better stink sprite from MrDoomBringer soon.

let the bikeshedding commence below!!!

@optimumtact

This comment has been minimized.

Copy link
Member

commented Dec 16, 2018

shower rooms are going to need lockers

@Wilchenx

This comment has been minimized.

Copy link
Contributor

commented Dec 16, 2018

does not affect mood

why bother then

@Qustinnus

This comment has been minimized.

Copy link
Member Author

commented Dec 16, 2018

because having a shitsmell sprite is literal virgin tier

@ninjanomnom

This comment has been minimized.

Copy link
Member

commented Dec 16, 2018

make it a biohazard symbol

@Wilchenx

This comment has been minimized.

Copy link
Contributor

commented Dec 16, 2018

make having low hygiene and wounds give you gangrene and infections :^)

@Qustinnus

This comment has been minimized.

Copy link
Member Author

commented Dec 16, 2018

now that is something I would consider.

@Tlaltecuhtli

This comment has been minimized.

Copy link
Contributor

commented Dec 16, 2018

make smelly cultists turn into nurgle cultists

@Qustinnus Qustinnus requested a review from Cyberboss as a code owner Dec 16, 2018

@Ziiro

This comment has been minimized.

Copy link

commented Dec 16, 2018

Either:

  1. Make the smell affect everyone elses' moodlets
  2. You emit misma at maximum smell
@Qustinnus

This comment has been minimized.

Copy link
Member Author

commented Dec 16, 2018

the first one is shit to do because we dont have anything that properly resembles a multi-tile collision box that I could receive Enter() and Exit() events from.

@Wilchenx

This comment has been minimized.

Copy link
Contributor

commented Dec 16, 2018

corpses emitting miasma would be cool and would actually make morgue fucking important

a neat concept to consider

@Qustinnus

This comment has been minimized.

Copy link
Member Author

commented Dec 16, 2018

:^) such a good idea that someone already added that a few months back

@SpaceManiac

This comment has been minimized.

Copy link
Member

commented Dec 16, 2018

we dont have anything that properly resembles a multi-tile collision box that I could receive Enter() and Exit() events from.

There's fields, which peacekeeper borgs use, don't remember if they actually work properly though.

@Qustinnus

This comment has been minimized.

Copy link
Member Author

commented Dec 16, 2018

Is there any documentation on them? the file that contains their code just confuses me.

@Qustinnus

This comment has been minimized.

Copy link
Member Author

commented Dec 16, 2018

anyways they make miasma when smelly now.

fix

@Qustinnus Qustinnus requested a review from duncathan as a code owner Dec 16, 2018

@Mickyan

This comment has been minimized.

Copy link
Contributor

commented Dec 16, 2018

I really don't like NEET tbh, it's every assistant greytider's wet dream. You get to ignore yet another feature and get almost a double increase in paycheck for just one point.

@Qustinnus

This comment has been minimized.

Copy link
Member Author

commented Dec 16, 2018

NEET just gives them 20 bucks per paycheck and makes them like being smelly (as opposed to nothing happening when theyre smelly besides the miasma spawning).

I can lower the paycheck to 5-10. but a real powergamer wouldnt waste the point anyways.

@swindly

This comment has been minimized.

Copy link
Contributor

commented Dec 16, 2018

So I can force the crew to generate miasma by destroying the showers?

@Qustinnus

This comment has been minimized.

Copy link
Member Author

commented Dec 16, 2018

yeah and you can also do that by killing them.

they can optionally use sinks or soap to clean themselves.

@Wilchenx

This comment has been minimized.

Copy link
Contributor

commented Dec 16, 2018

will neets get a positive mood from holding dakimakuras?

@Qustinnus

This comment has been minimized.

Copy link
Member Author

commented Dec 16, 2018

we have those??

@epochayur

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2018

@Qustinnus I respect the work you've done but this is mechanical bloat, plain and simple. It's yet another factor of your character to keep up with that has no real difference on how you play the game or how others interact with you, outside of RP situations, on a low RP server. Hunger, I can maybe see. Moods are pushing it. This is too much.

@Qustinnus

This comment has been minimized.

Copy link
Member Author

commented Dec 18, 2018

i bet you dont clean blood of your clothes.

@optimumtact

This comment has been minimized.

Copy link
Member

commented Dec 18, 2018

Yall think epoch lives in a hovel and doesn't shower? he's taking this pretty personally!

@epochayur

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2018

my body is like a cast iron skillet

@subject217

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2018

can we add an earwax meter

@Wilchenx

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2018

@epochayur vg and tg are both "low roleplay" servers yet the difference in roleplay between them is ridiculous

as for "It's yet another factor of your character to keep up with that has no real difference on how you play the game or how others interact with you"

i agree

it should have a impact on the person that smells and others that feel that smell

"Moods are pushing it. This is too much."

No, this is too little

If you want a TTT server there's traitor deathmatch

@Qustinnus

This comment has been minimized.

Copy link
Member Author

commented Dec 18, 2018

i dont like adding moodlets to my own features that can be seen as controversial in their premier PR to prevent bikeshedding about it. Anyone is free to add stronger mood effects

@Wilchenx

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2018

make it a config and shift the blame on headmins for enabling it

@miniusAreas

This comment has been minimized.

Copy link

commented Dec 19, 2018

wtf i like quntinius now? the fuck is this feeling?

@zamolxius

This comment has been minimized.

Copy link

commented Dec 20, 2018

awesome

@PKPenguin321

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2018

*sniffff* yes yes quite pungent my dear

fuk
@MrDoomBringer MrDoomBringer referenced this pull request Dec 24, 2018
5 of 5 tasks complete
@zamolxius

This comment has been minimized.

Copy link

commented Dec 27, 2018

we lifebob now

@optimumtact optimumtact merged commit 0de28b7 into tgstation:master Jan 1, 2019

3 of 4 checks passed

Map Diff Renders - Pull Request #41986 No Modified Maps
Details
Diffs - Pull Request #41986 Icon Diffs
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tgstation-server added a commit that referenced this pull request Jan 1, 2019
@DaxDupont

This comment has been minimized.

Copy link
Contributor

commented Jan 4, 2019

Good fetish pr

@PKPenguin321

This comment has been minimized.

Copy link
Contributor

commented Jan 4, 2019

le green smoke has arrived

@subject217

This comment has been minimized.

Copy link
Contributor

commented Jan 4, 2019

who would win: one airtight, spaceproof hardsuit or le green smoke?

DominikPanic added a commit to DominikPanic/tgstation that referenced this pull request May 6, 2019
[READY]Humans now have hygiene (DOES NOT AFFECT MOOD GO AWAY MOODPOST鈥
鈥RS) (tgstation#41986)

cl Floyd / Qustinnus
tweak: You now have to be naked to get the nice shower moodlet, if you shower with clothes you get a bad moodie
add: Hygiene, you slowly become dirty over time, the more covered in blood you are the faster you will lose hygiene. When you are too dirty you will have a stink overlay. (Hygiene doesn't affect mood currently) It also spawns miasma slowly if you smell like shit.
add: adds NEET and neat traits. NEET's get 20 bucks social welfare extra and like being unhygienic, while neat people dislike being unhygienic and like being hygienic
/cl

This doesn't affect mood so plssss dont strawman in this PR about how I'm forcing you to shower or die or whatever

This PR is mostly visual and will allow for people to judge others for literaly being smelly as hell.

also NEET and neat traits which interact with being smelly. (neat likes hygiene, dislikes lack of it. NEETs like lack of hygiene and get some social welfare (20 bucks))
DominikPanic added a commit to DominikPanic/tgstation that referenced this pull request May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.