Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial hygiene tweaks #42312

Merged
merged 1 commit into from Jan 11, 2019

Conversation

@Qustinnus
Copy link
Member

commented Jan 10, 2019

馃啈 floyd / qustinnus
tweak: Hygiene now lowers slower when you are clean, and dirtiness rates for some clothing items have been nerfed.
tweak: some more clothes are okay to shower with now.
tweak: only 20% as much miasma is produced by low hygiene
/馃啈

a small PR that will atleast alleviate some grievances, while I work on a bigger PR to sort the other problems out.

miasma rates are lowered by 80%
you can now shower with shoes, heasdsets and gloves because they're neglectable at best.
you only lose 25% as much hygiene when youre clean as you did before
shoes gloves and hats have lowered hygiene draining rates when bloody as compared to before

@Qustinnus Qustinnus requested a review from duncathan as a code owner Jan 10, 2019

@coiax

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

Gonna be only Qustinnus, I'd replace the miasma emission with just a gradual series of mood penalties. In addition, when someone is truly stunk, they give negative moodlets and messages to everyone around them, (additional messages if someone with low hygiene gives you a hug, a la The Sims). I'd also consider making the green smoke less obvious, more subtle, give dirty people messages that they feel grubby.

Also, give people examine messages to see how dirty they feel.

@Qustinnus

This comment has been minimized.

Copy link
Member Author

commented Jan 10, 2019

im also thinking of removing miasma emission and creating my own, weaker, disease system thats less potent than miasma. I think mood penalties will probably be added but not too strong. besides that I'll make the smoke more transparent and add more feedback in the form of text (chat and examine).

most of that is planned for a bigger PR as mentioned in the OP, I just wanted something out quick so I can stop getting pitchforks yeeted at me.

@wesoda25

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

I don't suppose this is the proper place to bring it up, but whatever. I still don't get why it was necessary to limit showering to being naked (and now with some gear). When did it ever pose a real issue.

@Qustinnus

This comment has been minimized.

Copy link
Member Author

commented Jan 10, 2019

people told me it was dumb that people could shower with their clothes on so I removed the ability to shower with your clothes on.

I also think that getting attacked in the shower when youre weak is one of the few interesting ways an antag can get you without just murderboning you in the hallway, theft is also interesting. I do see a problem for security being robbed by greyshits and a segregated sec shower might be a good idea, (tfw bullied so hard you get a seperate shower)

@zxaber

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

I can agree on the need to remove clothing to shower, both for the good mood and to remove the stank thing, but I still think it's stupid to have a negative moodlet applied when you shower with clothes on. Having a moodlet that says "I sure am an idiot for showering with clothes on" rather than, y'know, "I sure am glad I'm no longer on fire" seems weird.

@hazamaitsuru

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

I was looking through the shower code earlier today and if I'm not missing something, showers don't extinguish mobs anymore. So it doesn't matter if you're burning or not!

@zxaber

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

So it's impossible to do surgery on a plasmeme now?

@tortellinitony

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

Honestly, neck items should generally be OK to shower with. I also think you should add athletic shorts cause they can be like swim trunks.

@tuypo1

This comment has been minimized.

Copy link

commented Jan 11, 2019

fuck no coiax both mood and hygine are already dumb enough without bringing them together.

@Qustinnus

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2019

showers do extuingish mobs, if not you should look at the guy who rewrote shower code.

I can remove the bad moodlet, though.

@Tlaltecuhtli

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

shouldnt athletic shorts and swimsuits be showerfriendly too?

@dr-bee

This comment has been minimized.

Copy link

commented Jan 11, 2019

shouldnt athletic shorts and swimsuits be showerfriendly too?

Would help with the nevernudes. There are dozens of us. DOZENS!

@Cyberboss

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

you can shower with shoes

Yes, officer, this PR right here

@Qustinnus

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2019

ok but people cried about it so what should i do cyberboss

@erwgd

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

I recommend you add showerokay to breath masks. A small mask would be fine, as IRL people on oxygen do shower while wearing a mask or cannula.

Consider making plasma envirosuits showerokay since they're similar in look and function to bio suits.

Wearing a bio suit lets you wear anything else for a good shower, even if you're wearing a mask and/or glasses. You should need to wear a bio hood if you want to wear headgear in the shower.

@Tlaltecuhtli

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

@Qustinnus dont listen to forum plebians, you can shower with athletic shorts just fine

@optimumtact optimumtact merged commit 8aa9a2a into tgstation:master Jan 11, 2019

2 of 4 checks passed

Diffs - Pull Request #42312 No Modified Icons
Details
Map Diff Renders - Pull Request #42312 No Modified Maps
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tgstation tgstation deleted a comment from subject217 Jan 11, 2019

tgstation-server added a commit that referenced this pull request Jan 11, 2019
DominikPanic added a commit to DominikPanic/tgstation that referenced this pull request May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can鈥檛 perform that action at this time.