Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caves Away Mission (for real this time) [DNM] #71188

Closed
wants to merge 115 commits into from

Conversation

MMMiracles
Copy link
Contributor

@MMMiracles MMMiracles commented Nov 9, 2022

About The Pull Request

A complete remake of the original Caves away mission, keeping a similar layout theme from the original while enhancing literally everything else about it.

Need a general idea of what's been changed?

  • Brand new layout, taking up the entire 255x255 z-level and using pretty much all of it to some effect.
  • 4 separate zones, each getting progressively more dangerous as you delve further into the mission.
  • Combat encounters and later on, entire zones are randomly picked from a curated list of locations that change every round. Harder to plan out dedicated routes if the caves never seem to stay the same!
  • Rich but dense rocks! The minerals down here are aplenty for actual mining, bear in mind these caves are much stronger than your usual mining zone and require more time to break through. As a side effect, most ranged mining equipment doesn't seem all that useful down here past shooting the local fauna.
  • An actual finale area! Can you put an end to whatever caused the disappearance of the mining crew and researchers?

Why It's Good For The Game

If away missions are going to be enabled, they should be set to a higher standard of mapping quality much like our regular stations while having enough challenge to encourage active teamwork between the crew instead of 1 or 2 people running through it for the best equipment before going back station-side. My main goal was creating something with enough variety and challenge that going into this feels like an actual expedition and not just another ruin for powerlooters to speed through. Hopefully this sets a new standard for these missions and shows people what kind of cool stuff you can do that isn't just stations or ruins.

Changelog

馃啈 MMMiracles
add: The Caves away mission has been completely revamped from the ground up!
add: See your local expeditions officer for more details on setting up an exploration crew.
/馃啈
image
image
image

@san7890 san7890 added the 馃搶 Test Merge Candidate This version will not be removed by actions when the PR is updated label Nov 9, 2022
## Uncomment to load one of the missions from awaymissionconfig.txt or away_missions/ at roundstart.
#ROUNDSTART_AWAY
ROUNDSTART_AWAY

## How long the delay is before the Away Mission gate opens. Default is half an hour.
## 600 is one minute.
GATEWAY_DELAY 18000
GATEWAY_DELAY 60

## The probability of the gateway mission being a config one
CONFIG_GATEWAY_CHANCE 0
CONFIG_GATEWAY_CHANCE 100
Copy link
Member

@san7890 san7890 Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wont matter as far as test-merging since the config doesn't get overwritten by repository changes but remove this before you un-DNM this.

/turf/open/floor/engine{
initial_gas_mix = "LAVALAND_ATMOS"
},
Copy link
Member

@san7890 san7890 Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a subtype (and any other instances where you manually edit initial_gas_mix) because otherwise some new mapper will pick it up not understanding that it's been varedited and cause fifty jillion Active Turfs

@github-actions github-actions bot requested a review from san7890 Nov 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022

This pull request was test merged in 303 round(s).

Round list

bagil

terry

sybil

manuel

@ATH1909
Copy link
Contributor

ATH1909 commented Nov 10, 2022

does this have my BOY the away mission skeleton in it

also damn I respect the effort that went into making a (non-static!) map this big

@dragomagol
Copy link
Member

dragomagol commented Nov 10, 2022

Caused a pretty severe amount of runtimes from the boss actions in https://tgstation13.org/parsed-logs/manuel/data/logs/2022/11/10/round-194045

image

image

@MrMelbert
Copy link
Contributor

MrMelbert commented Nov 10, 2022

MDB crying at this PR

@MMMiracles
Copy link
Contributor Author

MMMiracles commented Nov 10, 2022

well the boss needs remade ANYWAY....

@san7890 san7890 added this to the Away Missions milestone Nov 11, 2022
@dragomagol
Copy link
Member

dragomagol commented Nov 12, 2022

#71211 some issues for ya

Revert When Necessary
@san7890
Copy link
Member

san7890 commented Nov 13, 2022

@MMMiracles I'm hearing reports of issues that apparently the map maker is able to "walk through" the portal behind them to teleport to the start of the map, which means that without doing much of any work- they're able to get a meteor pen and the other loot since the map maker is at the start of the map and monologues to drop said pen (or can be killed easily).

I'm going to push a commit that removes the meteorgun pen (because adding the NO_TELEPORT trait wouldn't do much of anything since they're going to be forcemoved if they bump into the teleporter), look into this when you're next able to. I know that you're somewhat busy with the whole basic mobs thing, so just let me know if you wanna change stuff around.

Revert it when this doesn't happen anymore. Thank you for your hard work up until now.

@san7890
Copy link
Member

san7890 commented Nov 13, 2022

Probably okay to re-add the meteor pen after #71248 goes through and you give the mapmaker/whoever the NO_TELEPORT trait? I'm not decided on how I feel about it for now, but I just don't want it to be painfully easy to get the pen with little work.

@Addust
Copy link
Contributor

Addust commented Nov 14, 2022

I've taken a look at this in SDMM and it is quite possibly the best-crafted away mission in history.

yes i'm biased towards ratvar

@Addust
Copy link
Contributor

Addust commented Nov 14, 2022

https://gyazo.com/93f567e7308e3b25095e39dead6de633 terminal on wrong side

@Whoneedspacee
Copy link
Contributor

Whoneedspacee commented Nov 17, 2022

I love it please make more

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label Nov 25, 2022
@Time-Green Time-Green added RED LABEL This PR will not auto stale, this label should be green at all times. and removed Stale Even the uncaring universe rejects you, why even go on labels Nov 27, 2022
@optimumtact
Copy link
Member

optimumtact commented Dec 1, 2022

Mmm san? what's happening here.

@san7890
Copy link
Member

san7890 commented Dec 1, 2022

Mmm san? what's happening here.

@optimumtact the whole project is on hold since all of the new simple animals introduced need to be reworked into the basic mob system and that'll have to happen whenever MMM gets the time/strength/whatever to do that

i haven't testmerged it in weeks since there's no need for more data on the map itself (we got lots of feedback already), and unless @MMMiracles is imminently working on reworking the mobs to be basic subtype, there's not much purpose to it still being on the PR tracker.

@san7890
Copy link
Member

san7890 commented Dec 1, 2022

I spoke with MMM over Discord and they said that they were going to focus on Tram for a bit and they would come back to it later (major hurdle being the required basic mob rework), but nothing imminent incoming.

Any maintainer is free to re-open this on request of MMM (as well as them being free to make a new PR should they choose to take that approach), this is only being closed so it doesn't remain useless on the tracker.

@san7890 san7890 closed this Dec 1, 2022
@san7890 san7890 removed RED LABEL This PR will not auto stale, this label should be green at all times. 馃搶 Test Merge Candidate This version will not be removed by actions when the PR is updated labels Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config Update Time to bother the headadmins for three months to get your config applied Do Not Merge You must have really upset someone Feature Exposes new bugs in interesting ways Map Edit Thank you for your tile-placing service. It's always appreciated. Sound Oh god my ears, they bleed, did you normalise the volume? Sprites A bikeshed full of soulless bikes. UI We make the game less playable, but with round edges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet