Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Should "singlebackup" be removed. #20

Closed
tgxn opened this Issue Oct 7, 2011 · 5 comments

Comments

Projects
None yet
3 participants
Owner

tgxn commented Oct 7, 2011

Should this be removed, as i do not see why anyone would want this, and it also makes the deleteOldBackups() not very accurate.

if (settings.getBooleanProperty("singlebackup")) {

I will leave a comment in the code referring to this issue.

lycano commented Oct 10, 2011

well if we change the whole backup routine then i would say yes, cause we have to play with libzip very hard to get both working (we have to code it for both seperatelly).

I would suggest you announce an upcoming change in the thread like "we plan to remove this feature and implement a new more flexible routine" .. to see the reaction on that ^^

@ghost ghost assigned tgxn Oct 13, 2011

Owner

tgxn commented Oct 13, 2011

Removing in next release.

@tgxn tgxn closed this Oct 14, 2011

Well... yes... I'm to late now, I know.
But:
http://forums.bukkit.org/posts/750409

Owner

tgxn commented Oct 17, 2011

gamerx#26

No, It should not.

@tgxn tgxn reopened this Oct 17, 2011

@tgxn tgxn closed this Oct 17, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment