{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":90747899,"defaultBranch":"master","name":"cli","ownerLogin":"thaJeztah","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2017-05-09T13:18:29.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1804568?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1720190533.0","currentOid":""},"activityList":{"items":[{"before":"233e5fc11fa3b7d897b45eae0a312ddf8b3f114b","after":"0644a0b5b65686294378f11585242ecd4d391b3c","ref":"refs/heads/completion_improvements","pushedAt":"2024-07-05T23:53:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli/command/container: add completion for --stop-signal\n\nWith this patch:\n\n docker run --stop-signal \n ABRT IOT RTMAX-4 RTMIN RTMIN+11 TSTP\n ALRM KILL RTMAX-5 RTMIN+1 RTMIN+12 TTIN\n BUS PIPE RTMAX-6 RTMIN+2 RTMIN+13 TTOU\n CHLD POLL RTMAX-7 RTMIN+3 RTMIN+14 URG\n CLD PROF RTMAX-8 RTMIN+4 RTMIN+15 USR1\n CONT PWR RTMAX-9 RTMIN+5 SEGV USR2\n FPE QUIT RTMAX-10 RTMIN+6 STKFLT VTALRM\n HUP RTMAX RTMAX-11 RTMIN+7 STOP WINCH\n ILL RTMAX-1 RTMAX-12 RTMIN+8 SYS XCPU\n INT RTMAX-2 RTMAX-13 RTMIN+9 TERM XFSZ\n IO RTMAX-3 RTMAX-14 RTMIN+10 TRAP\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli/command/container: add completion for --stop-signal"}},{"before":"d7e0a665e8e5552ad6f38a4d3e421ceef0bd294e","after":"233e5fc11fa3b7d897b45eae0a312ddf8b3f114b","ref":"refs/heads/completion_improvements","pushedAt":"2024-07-05T23:51:34.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli/command/container: add completion for --stop-signal\n\nWith this patch:\n\n docker run --stop-signal \n ABRT IOT RTMAX-4 RTMIN RTMIN+11 TSTP\n ALRM KILL RTMAX-5 RTMIN+1 RTMIN+12 TTIN\n BUS PIPE RTMAX-6 RTMIN+2 RTMIN+13 TTOU\n CHLD POLL RTMAX-7 RTMIN+3 RTMIN+14 URG\n CLD PROF RTMAX-8 RTMIN+4 RTMIN+15 USR1\n CONT PWR RTMAX-9 RTMIN+5 SEGV USR2\n FPE QUIT RTMAX-10 RTMIN+6 STKFLT VTALRM\n HUP RTMAX RTMAX-11 RTMIN+7 STOP WINCH\n ILL RTMAX-1 RTMAX-12 RTMIN+8 SYS XCPU\n INT RTMAX-2 RTMAX-13 RTMIN+9 TERM XFSZ\n IO RTMAX-3 RTMAX-14 RTMIN+10 TRAP\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli/command/container: add completion for --stop-signal"}},{"before":"d7adb4958bc826fcaa219f300b398c7d5f637530","after":"d7e0a665e8e5552ad6f38a4d3e421ceef0bd294e","ref":"refs/heads/completion_improvements","pushedAt":"2024-07-05T23:48:28.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli/command/container: add completion for --stop-signal\n\nWith this patch:\n\n docker run --stop-signal \n ABRT IOT RTMAX-4 RTMIN RTMIN+11 TSTP\n ALRM KILL RTMAX-5 RTMIN+1 RTMIN+12 TTIN\n BUS PIPE RTMAX-6 RTMIN+2 RTMIN+13 TTOU\n CHLD POLL RTMAX-7 RTMIN+3 RTMIN+14 URG\n CLD PROF RTMAX-8 RTMIN+4 RTMIN+15 USR1\n CONT PWR RTMAX-9 RTMIN+5 SEGV USR2\n FPE QUIT RTMAX-10 RTMIN+6 STKFLT VTALRM\n HUP RTMAX RTMAX-11 RTMIN+7 STOP WINCH\n ILL RTMAX-1 RTMAX-12 RTMIN+8 SYS XCPU\n INT RTMAX-2 RTMAX-13 RTMIN+9 TERM XFSZ\n IO RTMAX-3 RTMAX-14 RTMIN+10 TRAP\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli/command/container: add completion for --stop-signal"}},{"before":"8aae16b9efb45a88935c4abbc24d24d2a7a94c41","after":"d7adb4958bc826fcaa219f300b398c7d5f637530","ref":"refs/heads/completion_improvements","pushedAt":"2024-07-05T23:47:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli/command/container: add completion for --stop-signal\n\nWith this patch:\n\n docker run --stop-signal \n ABRT IOT RTMAX-4 RTMIN RTMIN+11 TSTP\n ALRM KILL RTMAX-5 RTMIN+1 RTMIN+12 TTIN\n BUS PIPE RTMAX-6 RTMIN+2 RTMIN+13 TTOU\n CHLD POLL RTMAX-7 RTMIN+3 RTMIN+14 URG\n CLD PROF RTMAX-8 RTMIN+4 RTMIN+15 USR1\n CONT PWR RTMAX-9 RTMIN+5 SEGV USR2\n FPE QUIT RTMAX-10 RTMIN+6 STKFLT VTALRM\n HUP RTMAX RTMAX-11 RTMIN+7 STOP WINCH\n ILL RTMAX-1 RTMAX-12 RTMIN+8 SYS XCPU\n INT RTMAX-2 RTMAX-13 RTMIN+9 TERM XFSZ\n IO RTMAX-3 RTMAX-14 RTMIN+10 TRAP\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli/command/container: add completion for --stop-signal"}},{"before":"683bc019d50a15415d987eb5686d069c278f850b","after":"8aae16b9efb45a88935c4abbc24d24d2a7a94c41","ref":"refs/heads/completion_improvements","pushedAt":"2024-07-05T22:58:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli/command/container: add completion for --volumes-from\n\nWith this patch:\n\n docker run --volumes-from amazing_nobel\n amazing_cannon boring_wozniak determined_banzai\n elegant_solomon reverent_booth amazing_nobel\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli/command/container: add completion for --volumes-from"}},{"before":"c96ca626d9025abea47354aa3cb466deaebe3f49","after":"683bc019d50a15415d987eb5686d069c278f850b","ref":"refs/heads/completion_improvements","pushedAt":"2024-07-05T22:52:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli/command/container: add completion for --restart\n\nWith this patch:\n\n docker run --restart \n always no on-failure unless-stopped\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli/command/container: add completion for --restart"}},{"before":"209b6346db9e094087444f6069694268ac67f221","after":"c96ca626d9025abea47354aa3cb466deaebe3f49","ref":"refs/heads/completion_improvements","pushedAt":"2024-07-05T22:19:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli/command/container: add completion for --cap-add, --cap-drop\n\nWith this patch:\n\n docker run --cap-add \n ALL CAP_KILL CAP_SETUID\n CAP_AUDIT_CONTROL CAP_LEASE CAP_SYSLOG\n CAP_AUDIT_READ CAP_LINUX_IMMUTABLE CAP_SYS_ADMIN\n CAP_AUDIT_WRITE CAP_MAC_ADMIN CAP_SYS_BOOT\n CAP_BLOCK_SUSPEND CAP_MAC_OVERRIDE CAP_SYS_CHROOT\n CAP_BPF CAP_MKNOD CAP_SYS_MODULE\n CAP_CHECKPOINT_RESTORE CAP_NET_ADMIN CAP_SYS_NICE\n CAP_CHOWN CAP_NET_BIND_SERVICE CAP_SYS_PACCT\n CAP_DAC_OVERRIDE CAP_NET_BROADCAST CAP_SYS_PTRACE\n CAP_DAC_READ_SEARCH CAP_NET_RAW CAP_SYS_RAWIO\n CAP_FOWNER CAP_PERFMON CAP_SYS_RESOURCE\n CAP_FSETID CAP_SETFCAP CAP_SYS_TIME\n CAP_IPC_LOCK CAP_SETGID CAP_SYS_TTY_CONFIG\n CAP_IPC_OWNER CAP_SETPCAP CAP_WAKE_ALARM\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli/command/container: add completion for --cap-add, --cap-drop"}},{"before":null,"after":"209b6346db9e094087444f6069694268ac67f221","ref":"refs/heads/completion_improvements","pushedAt":"2024-07-05T14:42:13.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli/command/container: add completion for --cap-add, --cap-drop\n\nWith this patch:\n\n docker run --cap-add \n ALL CAP_KILL CAP_SETUID\n CAP_AUDIT_CONTROL CAP_LEASE CAP_SYSLOG\n CAP_AUDIT_READ CAP_LINUX_IMMUTABLE CAP_SYS_ADMIN\n CAP_AUDIT_WRITE CAP_MAC_ADMIN CAP_SYS_BOOT\n CAP_BLOCK_SUSPEND CAP_MAC_OVERRIDE CAP_SYS_CHROOT\n CAP_BPF CAP_MKNOD CAP_SYS_MODULE\n CAP_CHECKPOINT_RESTORE CAP_NET_ADMIN CAP_SYS_NICE\n CAP_CHOWN CAP_NET_BIND_SERVICE CAP_SYS_PACCT\n CAP_DAC_OVERRIDE CAP_NET_BROADCAST CAP_SYS_PTRACE\n CAP_DAC_READ_SEARCH CAP_NET_RAW CAP_SYS_RAWIO\n CAP_FOWNER CAP_PERFMON CAP_SYS_RESOURCE\n CAP_FSETID CAP_SETFCAP CAP_SYS_TIME\n CAP_IPC_LOCK CAP_SETGID CAP_SYS_TTY_CONFIG\n CAP_IPC_OWNER CAP_SETPCAP CAP_WAKE_ALARM\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli/command/container: add completion for --cap-add, --cap-drop"}},{"before":"9610e630741c6bb1758cdb7c5d113f2501131815","after":"c0e6001ebc14ac5ca0b288acf82508ec960ab651","ref":"refs/heads/dev_completion","pushedAt":"2024-07-05T13:24:34.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"Makefile: add completion target\n\nAdd a \"completion\" target to install the generated completion\nscripts inside the dev-container. As generating this script\ndepends on the docker binary, it calls \"make binary\" first.\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"Makefile: add completion target"}},{"before":"f8e5f7b3ac8a9c99eb8ae46738821982b30601ea","after":"882d0706837f1ca535de1909eadc47616e2a31d1","ref":"refs/heads/cleanup_run_errors","pushedAt":"2024-07-05T11:07:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli/command/container: remove reportError, and put StatusError to use\n\nThe `reportError` utility was present because cli.StatusError would print\nthe error decorated with `Status: , Code: `.\nThat was not desirable in many cases as it would mess-up the output. To\nprevent this, the CLI had code to check for an empty `Status` (error message)\nin which case the error would be \"ignored\" (and only used for the exit-status),\nand the `reportError` utility would be used to manually print a custom error\nmessage before returning the error.\n\nNow that bca209006153d3e025cb3d31c3cd55eb2aec0c4f fixed the output format\nof `cli.StatusError`, and 3dd6fc365d853e21f0e11f9e6ab62c4f8ae438e7 and\n350a0b68a9584ec9ae712b6eca906c1018ba6dac no longer discard these error,\nwe can get rid of this utility, and just set the error-message for\nthe status-error.\n\nThis patch:\n\n- Introduces a `withHelp` which takes care of decorating errors with\n a \"Run --help\" hint for the user.\n- Introduces a `toStatusError` utility that detects certain errors in\n the container to assign a corresponding exit-code (these error-codes\n can be used to distinguish \"client\" errors from \"container\" errors).\n- Removes the `reportError` utility, and removes code that manually\n printed errors before returning.\n\nBehavior is mostly unmodified, with the exception of some slight reformatting\nof the errors:\n\n- `withHelp` adds a `docker:` prefix to the error, to indicate the error\n is produced by the `docker` command. This prefix was already present\n in most cases.\n- The \"--help\" hint is slightly updated (\"Run 'docker run --help' for\n more information\" instead of \"See 'docker run --help'\"), to make it\n more clear that it's a \"call to action\".\n- An empty is added before the \"--help\" hint to separate it better from\n the error-message.\n\nBefore this patch:\n\n $ docker run --pull=invalid-option alpine\n docker: invalid pull option: 'invalid-option': must be one of \"always\", \"missing\" or \"never\".\n See 'docker run --help'.\n $ echo $?\n 125\n\n $ docker run --rm alpine nosuchcommand\n docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: \"nosuchcommand\": executable file not found in $PATH: unknown.\n $ echo $?\n 127\n\nWith this patch:\n\n $ docker run --pull=invalid-option alpine\n docker: invalid pull option: 'invalid-option': must be one of \"always\", \"missing\" or \"never\"\n\n Run 'docker run --help' for more information\n $ echo $?\n 125\n\n $ docker run --rm alpine nosuchcommand\n docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: \"nosuchcommand\": executable file not found in $PATH: unknown.\n\n Run 'docker run --help' for more information\n $ echo $?\n 127\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli/command/container: remove reportError, and put StatusError to use"}},{"before":null,"after":"f8e5f7b3ac8a9c99eb8ae46738821982b30601ea","ref":"refs/heads/cleanup_run_errors","pushedAt":"2024-07-05T10:55:13.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli/command/container: remove reportError, and put StatusError to use\n\nThe `reportError` utility was present because cli.StatusError would print\nthe error decorated with `Status: , Code: `.\nThat was not desirable in many cases as it would mess-up the output. To\nprevent this, the CLI had code to check for an empty `Status` (error message)\nin which case the error would be \"ignored\" (and only used for the exit-status),\nand the `reportError` utility would be used to manually print a custom error\nmessage before returning the error.\n\nNow that bca209006153d3e025cb3d31c3cd55eb2aec0c4f fixed the output format\nof `cli.StatusError`, and 3dd6fc365d853e21f0e11f9e6ab62c4f8ae438e7 and\n350a0b68a9584ec9ae712b6eca906c1018ba6dac no longer discard these error,\nwe can get rid of this utility, and just set the error-message for\nthe status-error.\n\nThis patch:\n\n- Introduces a `withHelp` which takes care of decorating errors with\n a \"Run --help\" hint for the user.\n- Introduces a `toStatusError` utility that detects certain errors in\n the container to assign a corresponding exit-code (these error-codes\n can be used to distinguish \"client\" errors from \"container\" errors).\n- Removes the `reportError` utility, and removes code that manually\n printed errors before returning.\n\nBehavior is mostly unmodified, with the exception of some slight reformatting\nof the errors:\n\n- `withHelp` adds a `docker:` prefix to the error, to indicate the error\n is produced by the `docker` command. This prefix was already present\n in most cases.\n- The \"--help\" hint is slightly updated (\"Run 'docker run --help' for\n more information\" instead of \"See 'docker run --help'\"), to make it\n more clear that it's a \"call to action\".\n- An empty is added before the \"--help\" hint to separate it better from\n the error-message.\n\nBefore this patch:\n\n $ docker run --pull=invalid-option alpine\n docker: invalid pull option: 'invalid-option': must be one of \"always\", \"missing\" or \"never\".\n See 'docker run --help'.\n $ echo $?\n 125\n\n $ docker run --rm alpine nosuchcommand\n docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: \"nosuchcommand\": executable file not found in $PATH: unknown.\n $ echo $?\n 127\n\nWith this patch:\n\n $ docker run --pull=invalid-option alpine\n docker: invalid pull option: 'invalid-option': must be one of \"always\", \"missing\" or \"never\"\n\n Run 'docker run --help' for more information\n $ echo $?\n 125\n\n $ docker run --rm alpine nosuchcommand\n docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: \"nosuchcommand\": executable file not found in $PATH: unknown.\n\n Run 'docker run --help' for more information\n $ echo $?\n 127\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli/command/container: remove reportError, and put StatusError to use"}},{"before":"cad08ff3b189d22973c31f6aacee968c5690b88a","after":"61c6ff2d4a8efafb191aafdd4ff8ec4fdbf3cf81","ref":"refs/heads/master","pushedAt":"2024-07-05T09:49:27.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"Merge pull request #5229 from thaJeztah/exit_error\n\ncmd/docker: split handling exit-code to a separate utility","shortMessageHtmlLink":"Merge pull request docker#5229 from thaJeztah/exit_error"}},{"before":"eae75092a0e4b7d3cbb5d02145a75c01f1bd6bbe","after":null,"ref":"refs/heads/exit_error","pushedAt":"2024-07-05T09:47:33.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"}},{"before":"7c4d8aa7147302c92daacac9a84d570147c479f1","after":"5f0f0dd8a6f481cc913b0726ea0de9d12a94d8be","ref":"refs/heads/nicer_errors","pushedAt":"2024-07-05T09:15:17.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli: FlagErrorFunc: don't print long usage output for invalid flags\n\nWhen trying to use an invalid flag, the CLI currently prints the a short\nerror message, instructions to use the `--help` flag to learn about the\ncorrect usage, followed by the command's usage output.\n\nWhile this is a common convention, and may have been a nice gesture when\ndocker was still young and only had a few commands and options (\"you did\nsomething wrong, but here's an overview of what you can use\"), that's no\nlonger the case, and many commands have a _very_ long output.\n\nThe result of this is that the error message, which is the relevant\ninformation in this case - \"You mis-typed something\" - is lost in the\noutput, and hard to find (sometimes even requiring scrolling back).\n\nThe output is also confusing, because it _looks_ like something ran\nsuccessfully (most of the output is not about the error!).\n\nEven further; the suggested resolution (try `--help` to see the correct\noptions) is rather redundant, because running teh command with `--help`\nproduces _exactly_ the same output as was just showh, baring the error\nmessage. As a fun fact, due to the usage output being printed, the\noutput even contains not one, but _two_ \"call to actions\";\n\n- `See 'docker volume --help'.` (under the erro message)\n- `Run 'docker volume COMMAND --help' for more information on a command.`\n (under the usage output)\n\nIn short; the output is too verbose, confusing, and doesn't provide\na good UX. Let's reduce the output produced so that the focus is on the\nimportant information.\n\nThis patch:\n\n- Changes the usage to the short-usage.\n- Prefixes the error message with the binary / root-command name\n (usually `docker:`) to be consistent with `unknon command`, and helps\n to distinguish where the message originated from (the `docker` CLI in\n this case).\n- Adds an empty line between the error-message and the \"call to action\"\n (`Run 'docker volume --help' ...` in the example below). This helps\n separating the error message (\"unkown flag\") from the call-to-action.\n\nBefore this patch:\n\n docker volume --no-such-flag\n unknown flag: --no-such-flag\n See 'docker volume --help'.\n\n Usage: docker volume COMMAND\n\n Manage volumes\n\n Commands:\n create Create a volume\n inspect Display detailed information on one or more volumes\n ls List volumes\n prune Remove unused local volumes\n rm Remove one or more volumes\n update Update a volume (cluster volumes only)\n\n Run 'docker volume COMMAND --help' for more information on a command.\n\nWith this patch:\n\n docker volume --no-such-flag\n docker: unknown flag: --no-such-flag\n\n Usage: docker volume COMMAND\n\n Run 'docker volume --help' for more information\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli: FlagErrorFunc: don't print long usage output for invalid flags"}},{"before":"d5aa99aa265116547960f00e66035f06932a1991","after":"7c4d8aa7147302c92daacac9a84d570147c479f1","ref":"refs/heads/nicer_errors","pushedAt":"2024-07-05T09:08:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli: FlagErrorFunc: don't print long usage output for invalid flags\n\nWhen trying to use an invalid flag, the CLI currently prints the a short\nerror message, instructions to use the `--help` flag to learn about the\ncorrect usage, followed by the command's usage output.\n\nWhile this is a common convention, and may have been a nice gesture when\ndocker was still young and only had a few commands and options (\"you did\nsomething wrong, but here's an overview of what you can use\"), that's no\nlonger the case, and many commands have a _very_ long output.\n\nThe result of this is that the error message, which is the relevant\ninformation in this case - \"You mis-typed something\" - is lost in the\noutput, and hard to find (sometimes even requiring scrolling back).\n\nThe output is also confusing, because it _looks_ like something ran\nsuccessfully (most of the output is not about the error!).\n\nEven further; the suggested resolution (try `--help` to see the correct\noptions) is rather redundant, because running teh command with `--help`\nproduces _exactly_ the same output as was just showh, baring the error\nmessage. As a fun fact, due to the usage output being printed, the\noutput even contains not one, but _two_ \"call to actions\";\n\n- `See 'docker volume --help'.` (under the erro message)\n- `Run 'docker volume COMMAND --help' for more information on a command.`\n (under the usage output)\n\nIn short; the output is too verbose, confusing, and doesn't provide\na good UX. Let's reduce the output produced so that the focus is on the\nimportant information.\n\nThis patch:\n\n- Changes the usage to the short-usage.\n- Adds an empty line between the error-message and the \"call to action\"\n (`Run 'docker volume --help' ...` in the example below). This helps\n separating the error message (\"unkown flag\") from the call-to-action.\n\nBefore this patch:\n\n docker volume --no-such-flag\n unknown flag: --no-such-flag\n See 'docker volume --help'.\n\n Usage: docker volume COMMAND\n\n Manage volumes\n\n Commands:\n create Create a volume\n inspect Display detailed information on one or more volumes\n ls List volumes\n prune Remove unused local volumes\n rm Remove one or more volumes\n update Update a volume (cluster volumes only)\n\n Run 'docker volume COMMAND --help' for more information on a command.\n\nWith this patch:\n\n docker volume --no-such-flag\n unknown flag: --no-such-flag\n\n Usage: docker volume COMMAND\n\n Run 'docker volume --help' for more information\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli: FlagErrorFunc: don't print long usage output for invalid flags"}},{"before":"d6a2a4ec79fed95e11b5513ec7e9af75336feed3","after":"d5aa99aa265116547960f00e66035f06932a1991","ref":"refs/heads/nicer_errors","pushedAt":"2024-07-05T09:03:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli: FlagErrorFunc: don't print long usage output for invalid flags\n\nWhen trying to use an invalid flag, the CLI currently prints the a short\nerror message, instructions to use the `--help` flag to learn about the\ncorrect usage, followed by the command's usage output.\n\nWhile this is a common convention, and may have been a nice gesture when\ndocker was still young and only had a few commands and options (\"you did\nsomething wrong, but here's an overview of what you can use\"), that's no\nlonger the case, and many commands have a _very_ long output.\n\nThe result of this is that the error message, which is the relevant\ninformation in this case - \"You mis-typed something\" - is lost in the\noutput, and hard to find (sometimes even requiring scrolling back).\n\nThe output is also confusing, because it _looks_ like something ran\nsuccessfully (most of the output is not about the error!).\n\nEven further; the suggested resolution (try `--help` to see the correct\noptions) is rather redundant, because running teh command with `--help`\nproduces _exactly_ the same output as was just showh, baring the error\nmessage. As a fun fact, due to the usage output being printed, the\noutput even contains not one, but _two_ \"call to actions\";\n\n- `See 'docker volume --help'.` (under the erro message)\n- `Run 'docker volume COMMAND --help' for more information on a command.`\n (under the usage output)\n\nIn short; the output is too verbose, confusing, and doesn't provide\na good UX. Let's reduce the output produced so that the focus is on the\nimportant information.\n\nThis patch:\n\n- Changes the usage to the short-usage.\n- Prefixes the error message with the binary / root-command name\n (usually `docker:`); this is something we can still decide on, but\n it's a pattern we already use in some places. The motivation for this\n is that `docker` commands can often produce output that's a combination\n of output from the CLI itself, output from the daemon, and even output\n from the container. The `docker:` prefix helps to distinguish where\n the message originated from (the `docker` CLI in this case).\n- Adds an empty line between the error-message and the \"call to action\"\n (`See 'docker volume --help'.` in the example below). This helps\n separating the error message (\"unkown flag\") from the call-to-action.\n\nBefore this patch:\n\n docker volume --no-such-flag\n unknown flag: --no-such-flag\n See 'docker volume --help'.\n\n Usage: docker volume COMMAND\n\n Manage volumes\n\n Commands:\n create Create a volume\n inspect Display detailed information on one or more volumes\n ls List volumes\n prune Remove unused local volumes\n rm Remove one or more volumes\n update Update a volume (cluster volumes only)\n\n Run 'docker volume COMMAND --help' for more information on a command.\n\nWith this patch:\n\n docker volume --no-such-flag\n docker: unknown flag: --no-such-flag\n\n Usage: docker volume COMMAND\n\n Run 'docker volume --help' for more information\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli: FlagErrorFunc: don't print long usage output for invalid flags"}},{"before":"c031b2ac2156284b44de1a6bb370b963e24fa5dc","after":"eae75092a0e4b7d3cbb5d02145a75c01f1bd6bbe","ref":"refs/heads/exit_error","pushedAt":"2024-07-05T09:02:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cmd/docker: split handling exit-code to a separate utility\n\nThis allows dockerMain() to return an error \"as usual\", and puts the\nresponsibility for turning that into an appropriate exit-code in\nmain() (which also sets the exit-code when terminating).\n\nWe could consider putting this utility in the cli package and exporting\nit if would be useful for doing a similar handling in plugins.\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cmd/docker: split handling exit-code to a separate utility"}},{"before":"d8efa58346b3d850ac679cec1b558cf30a841d5a","after":"c031b2ac2156284b44de1a6bb370b963e24fa5dc","ref":"refs/heads/exit_error","pushedAt":"2024-07-05T08:57:17.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cmd/docker: split handling exit-code to a separate utility\n\nThis allows dockerMain() to return an error \"as usual\", and puts the\nresponsibility for turning that into an appropriate exit-code in\nmain() (which also sets the exit-code when terminating).\n\nWe could consider putting this utility in the cli package and exporting\nit if would be useful for doing a similar handling in plugins.\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cmd/docker: split handling exit-code to a separate utility"}},{"before":"5aae44baaaad82d07cc852293bdb5769d322f59a","after":"cad08ff3b189d22973c31f6aacee968c5690b88a","ref":"refs/heads/master","pushedAt":"2024-07-05T08:51:34.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"Merge pull request #5231 from thaJeztah/prettier_exit_status\n\ncli: make cli.StatusError slightly prettier","shortMessageHtmlLink":"Merge pull request docker#5231 from thaJeztah/prettier_exit_status"}},{"before":"bca209006153d3e025cb3d31c3cd55eb2aec0c4f","after":null,"ref":"refs/heads/prettier_exit_status","pushedAt":"2024-07-05T08:50:50.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"}},{"before":"88896eeaabc73638fd184479d09e83c1e4e7c266","after":null,"ref":"refs/heads/clean_skip","pushedAt":"2024-07-05T08:49:54.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"}},{"before":"0a836a94c3745afff3cc9c67f4cb9c75a84526a2","after":"c60b360c33320aba9a7e6bad86d0226bf69156c0","ref":"refs/heads/nicer_missing_commands","pushedAt":"2024-07-05T01:35:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli: improve argument validation output\n\nImprove the output for these validation errors:\n\n- Removes the short command description from the output. This information\n does not provide much useful help, and distracts from the error message.\n- Reduces punctuation, and\n- Prefixes the error message with the binary / root-command name\n (usually `docker:`) to be consistent with other similar errors.\n- Adds an empty line between the error-message and the \"call to action\"\n (`Run 'docker volume --help'...` in the example below). This helps\n separating the error message and \"usage\" from the call-to-action.\n\nBefore this patch:\n\n $ docker volume ls one two three\n \"docker volume ls\" accepts no arguments.\n See 'docker volume ls --help'.\n\n Usage: docker volume ls [OPTIONS]\n\n List volumes\n\n $ docker volume create one two three\n \"docker volume create\" requires at most 1 argument.\n See 'docker volume create --help'.\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n Create a volume\n\nWith this patch:\n\n $ docker volume ls one two three\n docker: 'docker volume ls' accepts no arguments\n\n Usage: docker volume ls [OPTIONS]\n\n Run 'docker volume ls --help' for more information\n\n $ docker voludocker volume create one two three\n docker: 'docker volume create' requires at most 1 argument\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n SRun 'docker volume create --help' for more information\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli: improve argument validation output"}},{"before":"642bde5acca1301e8c74b834afe980b503a04a33","after":"0a836a94c3745afff3cc9c67f4cb9c75a84526a2","ref":"refs/heads/nicer_missing_commands","pushedAt":"2024-07-05T01:32:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli: improve argument validation output\n\nImprove the output for these validation errors:\n\n- Removes the short command description from the output. This information\n does not provide much useful help, and distracts from the error message.\n- Reduces punctuation, and\n- Prefixes the error message with the binary / root-command name\n (usually `docker:`) to be consistent with other similar errors.\n- Adds an empty line between the error-message and the \"call to action\"\n (`Run 'docker volume --help'...` in the example below). This helps\n separating the error message and \"usage\" from the call-to-action.\n\nBefore this patch:\n\n $ docker volume ls one two three\n \"docker volume ls\" accepts no arguments.\n See 'docker volume ls --help'.\n\n Usage: docker volume ls [OPTIONS]\n\n List volumes\n\n $ docker volume create one two three\n \"docker volume create\" requires at most 1 argument.\n See 'docker volume create --help'.\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n Create a volume\n\nWith this patch:\n\n $ docker volume ls one two three\n docker: 'docker volume ls' accepts no arguments\n\n Usage: docker volume ls [OPTIONS]\n\n Run 'docker volume ls --help' for more information\n\n $ docker voludocker volume create one two three\n docker: 'docker volume create' requires at most 1 argument\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n SRun 'docker volume create --help' for more information\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli: improve argument validation output"}},{"before":"346dac74af018a968a7a42ecb8f84bcae0d337b7","after":"642bde5acca1301e8c74b834afe980b503a04a33","ref":"refs/heads/nicer_missing_commands","pushedAt":"2024-07-05T01:26:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli: improve argument validation output\n\nImprove the output for these validation errors:\n\n- Removes the short command description from the output. This information\n does not provide much useful help, and distracts from the error message.\n- Reduces punctuation, and\n- Prefixes the error message with the binary / root-command name\n (usually `docker:`) to be consistent with other similar errors.\n- Adds an empty line between the error-message and the \"call to action\"\n (`Run 'docker volume --help'...` in the example below). This helps\n separating the error message and \"usage\" from the call-to-action.\n\nBefore this patch:\n\n $ docker volume ls one two three\n \"docker volume ls\" accepts no arguments.\n See 'docker volume ls --help'.\n\n Usage: docker volume ls [OPTIONS]\n\n List volumes\n\n $ docker volume create one two three\n \"docker volume create\" requires at most 1 argument.\n See 'docker volume create --help'.\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n Create a volume\n\nWith this patch:\n\n $ docker volume ls one two three\n docker: 'docker volume ls' accepts no arguments\n\n Usage: docker volume ls [OPTIONS]\n\n Run 'docker volume ls --help' for more information\n\n $ docker voludocker volume create one two three\n docker: 'docker volume create' requires at most 1 argument\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n SRun 'docker volume create --help' for more information\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli: improve argument validation output"}},{"before":"07cd5bfa275eac63ad7a55974974ce3c3d42a2ff","after":"346dac74af018a968a7a42ecb8f84bcae0d337b7","ref":"refs/heads/nicer_missing_commands","pushedAt":"2024-07-05T01:22:34.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli: improve argument validation output\n\nImprove the output for these validation errors:\n\n- Removes the short command description from the output. This information\n does not provide much useful help, and distracts from the error message.\n- Reduces punctuation, and\n- Prefixes the error message with the binary / root-command name\n (usually `docker:`) to be consistent with other similar errors.\n- Adds an empty line between the error-message and the \"call to action\"\n (`Run 'docker volume --help'...` in the example below). This helps\n separating the error message and \"usage\" from the call-to-action.\n\nBefore this patch:\n\n $ docker volume ls one two three\n \"docker volume ls\" accepts no arguments.\n See 'docker volume ls --help'.\n\n Usage: docker volume ls [OPTIONS]\n\n List volumes\n\n $ docker volume create one two three\n \"docker volume create\" requires at most 1 argument.\n See 'docker volume create --help'.\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n Create a volume\n\nWith this patch:\n\n $ docker volume ls one two three\n docker: 'docker volume ls' accepts no arguments\n\n Usage: docker volume ls [OPTIONS]\n\n Run 'docker volume ls --help' for more information\n\n $ docker voludocker volume create one two three\n docker: 'docker volume create' requires at most 1 argument\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n SRun 'docker volume create --help' for more information\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli: improve argument validation output"}},{"before":"46bcf817597c4a37725a509f06829c5c3ff2017f","after":"07cd5bfa275eac63ad7a55974974ce3c3d42a2ff","ref":"refs/heads/nicer_missing_commands","pushedAt":"2024-07-05T01:20:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli: improve argument validation output\n\nImprove the output for these validation errors:\n\n- Removes the short command description from the output. This information\n does not provide much useful help, and distracts from the error message.\n- Reduces punctuation, and\n- Prefixes the error message with the binary / root-command name\n (usually `docker:`) to be consistent with other similar errors.\n- Adds an empty line between the error-message and the \"call to action\"\n (`Run 'docker volume --help'...` in the example below). This helps\n separating the error message and \"usage\" from the call-to-action.\n\nBefore this patch:\n\n $ docker volume ls one two three\n \"docker volume ls\" accepts no arguments.\n See 'docker volume ls --help'.\n\n Usage: docker volume ls [OPTIONS]\n\n List volumes\n\n $ docker volume create one two three\n \"docker volume create\" requires at most 1 argument.\n See 'docker volume create --help'.\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n Create a volume\n\nWith this patch:\n\n $ docker volume ls one two three\n docker: 'docker volume ls' accepts no arguments\n\n Usage: docker volume ls [OPTIONS]\n\n Run 'docker volume ls --help' for more information\n\n $ docker voludocker volume create one two three\n docker: 'docker volume create' requires at most 1 argument\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n SRun 'docker volume create --help' for more information\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli: improve argument validation output"}},{"before":"77ccf7446c09a31db640efd0c72bc9fc2306cf58","after":"46bcf817597c4a37725a509f06829c5c3ff2017f","ref":"refs/heads/nicer_missing_commands","pushedAt":"2024-07-05T01:18:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli: improve argument validation output\n\nImprove the output for these validation errors:\n\n- Removes the short command description from the output. This information\n does not provide much useful help, and distracts from the error message.\n- Reduces punctuation, and\n- Prefixes the error message with the binary / root-command name\n (usually `docker:`) to be consistent with other similar errors.\n- Adds an empty line between the error-message and the \"call to action\"\n (`Run 'docker volume --help'...` in the example below). This helps\n separating the error message and \"usage\" from the call-to-action.\n\nBefore this patch:\n\n $ docker volume ls one two three\n \"docker volume ls\" accepts no arguments.\n See 'docker volume ls --help'.\n\n Usage: docker volume ls [OPTIONS]\n\n List volumes\n\n $ docker volume create one two three\n \"docker volume create\" requires at most 1 argument.\n See 'docker volume create --help'.\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n Create a volume\n\nWith this patch:\n\n $ docker volume ls one two three\n docker: 'docker volume ls' accepts no arguments\n\n Usage: docker volume ls [OPTIONS]\n\n Run 'docker volume ls --help' for more information\n\n $ docker voludocker volume create one two three\n docker: 'docker volume create' requires at most 1 argument\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n SRun 'docker volume create --help' for more information\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli: improve argument validation output"}},{"before":"b75f93494aa3640df3ae4299a6a561d910519400","after":"77ccf7446c09a31db640efd0c72bc9fc2306cf58","ref":"refs/heads/nicer_missing_commands","pushedAt":"2024-07-05T01:17:13.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli: improve argument validation output\n\nImprove the output for these validation errors:\n\n- Removes the short command description from the output. This information\n does not provide much useful help, and distracts from the error message.\n- Reduces punctuation, and\n- Prefixes the error message with the binary / root-command name\n (usually `docker:`) to be consistent with other similar errors.\n- Adds an empty line between the error-message and the \"call to action\"\n (`Run 'docker volume --help'...` in the example below). This helps\n separating the error message and \"usage\" from the call-to-action.\n\nBefore this patch:\n\n $ docker volume ls one two three\n \"docker volume ls\" accepts no arguments.\n See 'docker volume ls --help'.\n\n Usage: docker volume ls [OPTIONS]\n\n List volumes\n\n $ docker volume create one two three\n \"docker volume create\" requires at most 1 argument.\n See 'docker volume create --help'.\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n Create a volume\n\nWith this patch:\n\n $ docker volume ls one two three\n docker: 'docker volume ls' accepts no arguments\n\n Usage: docker volume ls [OPTIONS]\n\n Run 'docker volume ls --help' for more information\n\n $ docker voludocker volume create one two three\n docker: 'docker volume create' requires at most 1 argument\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n SRun 'docker volume create --help' for more information\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli: improve argument validation output"}},{"before":"3efd491956f6d276646cd8cdc9d2fe483c3fe915","after":"b75f93494aa3640df3ae4299a6a561d910519400","ref":"refs/heads/nicer_missing_commands","pushedAt":"2024-07-05T01:07:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli: improve argument validation output\n\nImprove the output for these validation errors:\n\n- Removes the short command description from the output. This information\n does not provide much useful help, and distracts from the error message.\n- Reduces punctuation, and\n- Prefixes the error message with the binary / root-command name\n (usually `docker:`) to be consistent with other similar errors.\n- Adds an empty line between the error-message and the \"call to action\"\n (`Run 'docker volume --help'...` in the example below). This helps\n separating the error message and \"usage\" from the call-to-action.\n\nBefore this patch:\n\n $ docker volume ls one two three\n \"docker volume ls\" accepts no arguments.\n See 'docker volume ls --help'.\n\n Usage: docker volume ls [OPTIONS]\n\n List volumes\n\n $ docker volume create one two three\n \"docker volume create\" requires at most 1 argument.\n See 'docker volume create --help'.\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n Create a volume\n\nWith this patch:\n\n $ docker volume ls one two three\n docker: 'docker volume ls' accepts no arguments\n\n Usage: docker volume ls [OPTIONS]\n\n Run 'docker volume ls --help' for more information\n\n $ docker voludocker volume create one two three\n docker: 'docker volume create' requires at most 1 argument\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n SRun 'docker volume create --help' for more information\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli: improve argument validation output"}},{"before":"5590f9acff44b6c1ef327083872ad62ba0f7c558","after":"3efd491956f6d276646cd8cdc9d2fe483c3fe915","ref":"refs/heads/nicer_missing_commands","pushedAt":"2024-07-05T01:04:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thaJeztah","name":"Sebastiaan van Stijn","path":"/thaJeztah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1804568?s=80&v=4"},"commit":{"message":"cli: improve argument validation output\n\nImprove the output for these validation errors:\n\n- Removes the short command description from the output. This information\n does not provide much useful help, and distracts from the error message.\n- Reduces punctuation, and\n- Prefixes the error message with the binary / root-command name\n (usually `docker:`) to be consistent with other similar errors.\n- Adds an empty line between the error-message and the \"call to action\"\n (`Run 'docker volume --help'...` in the example below). This helps\n separating the error message and \"usage\" from the call-to-action.\n\nBefore this patch:\n\n $ docker volume ls one two three\n \"docker volume ls\" accepts no arguments.\n See 'docker volume ls --help'.\n\n Usage: docker volume ls [OPTIONS]\n\n List volumes\n\n $ docker volume create one two three\n \"docker volume create\" requires at most 1 argument.\n See 'docker volume create --help'.\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n Create a volume\n\nWith this patch:\n\n $ docker volume ls one two three\n docker: 'docker volume ls' accepts no arguments\n\n Usage: docker volume ls [OPTIONS]\n\n Run 'docker volume ls --help' for more information\n\n $ docker voludocker volume create one two three\n docker: 'docker volume create' requires at most 1 argument\n\n Usage: docker volume create [OPTIONS] [VOLUME]\n\n SRun 'docker volume create --help' for more information\n\nSigned-off-by: Sebastiaan van Stijn ","shortMessageHtmlLink":"cli: improve argument validation output"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEeCzb3gA","startCursor":null,"endCursor":null}},"title":"Activity ยท thaJeztah/cli"}