Skip to content
Permalink
Branch: master
Commits on Jul 17, 2019
  1. Merge pull request from GHSA-99qr-h2rp-65rc

    thaJeztah committed Jul 17, 2019
    DebugRequestMiddleware: unconditionally scrub data field
Commits on Jul 16, 2019
  1. Merge pull request moby#39540 from andrewhsu/run-single-integration

    thaJeztah committed Jul 16, 2019
    allow running of single integration test
  2. Merge pull request moby#37147 from bachp/patch-1

    thaJeztah committed Jul 16, 2019
    Check for BRIDGE_VLAN_FILTERING in overlay section
  3. Merge pull request moby#39537 from thaJeztah/cdn_mirror_deb_security

    thaJeztah committed Jul 16, 2019
    Dockerfile: Use APT_MIRROR for security.debian.org as well
  4. Merge pull request moby#39329 from tiborvass/buildkit-honor-daemon-dn…

    thaJeztah committed Jul 16, 2019
    …sconfig
    
    build: buildkit now honors daemon's DNS config
  5. Dockerfile: Use APT_MIRROR for security.debian.org as well

    thaJeztah committed Jul 16, 2019
    The fastly cdn mirror we're using also mirrors the debian security
    repository;
    
    ```
    Welcome to deb.debian.org (fastly instance)!
    
    This is deb.debian.org. This service provides mirrors for the following Debian archive repositories:
    
    /debian/
    /debian-debug/
    /debian-ports/
    /debian-security/
    The server deb.debian.org does not have packages itself, but the name has SRV records in DNS that let apt in stretch and later find places.
    ```
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  6. Merge pull request moby#39527 from thaJeztah/pull_platform_regression

    thaJeztah committed Jul 16, 2019
    Fix error handling of incorrect --platform values
Commits on Jul 15, 2019
  1. Merge pull request moby#39529 from thaJeztah/remove_codecov

    thaJeztah committed Jul 15, 2019
    Remove Codecov
  2. Add regression tests for invalid platform status codes

    thaJeztah committed Jul 15, 2019
    Before we handled containerd errors, using an invalid platform produced a 500 status:
    
    ```bash
    curl -v \
      -X POST \
      --unix-socket /var/run/docker.sock \
      "http://localhost:2375/v1.40/images/create?fromImage=hello-world&platform=foobar&tag=latest" \
      -H "Content-Type: application/json"
    ```
    
    ```
    * Connected to localhost (docker.sock) port 80 (#0)
    > POST /v1.40/images/create?fromImage=hello-world&platform=foobar&tag=latest HTTP/1.1
    > Host: localhost:2375
    > User-Agent: curl/7.54.0
    > Accept: */*
    > Content-Type: application/json
    >
    < HTTP/1.1 500 Internal Server Error
    < Api-Version: 1.40
    < Content-Length: 85
    < Content-Type: application/json
    < Date: Mon, 15 Jul 2019 15:25:44 GMT
    < Docker-Experimental: true
    < Ostype: linux
    < Server: Docker/19.03.0-rc2 (linux)
    <
    {"message":"\"foobar\": unknown operating system or architecture: invalid argument"}
    ```
    
    That problem is now fixed, and the API correctly returns a 4xx status:
    
    ```bash
    curl -v \
      -X POST \
      --unix-socket /var/run/docker.sock \
      "http://localhost:2375/v1.40/images/create?fromImage=hello-world&platform=foobar&tag=latest" \
      -H "Content-Type: application/json"
    ```
    
    ```
    * Connected to localhost (/var/run/docker.sock) port 80 (#0)
    > POST /v1.40/images/create?fromImage=hello-world&platform=foobar&tag=latest HTTP/1.1
    > Host: localhost:2375
    > User-Agent: curl/7.52.1
    > Accept: */*
    > Content-Type: application/json
    >
    < HTTP/1.1 400 Bad Request
    < Api-Version: 1.41
    < Content-Type: application/json
    < Docker-Experimental: true
    < Ostype: linux
    < Server: Docker/dev (linux)
    < Date: Mon, 15 Jul 2019 15:13:42 GMT
    < Content-Length: 85
    <
    {"message":"\"foobar\": unknown operating system or architecture: invalid argument"}
    * Curl_http_done: called premature == 0
    ```
    
    This patch adds tests to validate the behaviour
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  3. errdefs: convert containerd errors to the correct status code

    thaJeztah committed Jul 15, 2019
    In situations where the containerd error is consumed directly
    and not received over gRPC, errors were not translated.
    
    This patch converts containerd errors to the correct HTTP
    status code.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  4. Remove Codecov

    thaJeztah committed Jul 15, 2019
    Codecov has shown to be flaky, and calculate the wrong diff, in
    addition, it doesn't show coverage for integration tests, which
    makes the coverage report not useful.
    
    Removing it for now, while we look at alternatives.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  5. Merge pull request moby#39525 from thaJeztah/sync_security_reporting

    thaJeztah committed Jul 15, 2019
    Update CONTRIBUTING.md to have an option to keep name anonymous if requested
  6. errdefs: remove unneeded recursive calls

    thaJeztah committed Jul 15, 2019
    The `statusCodeFromGRPCError` and `statusCodeFromDistributionError`
    helpers are used by `GetHTTPErrorStatusCode`, which already recurses
    if the error implements the `Causer` interface.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  7. Update CONTRIBUTING.md to have an option to keep name anonymous if re…

    thaJeztah committed Jul 15, 2019
    …quested
    
    Same changes as 1d792e6, which didn't
    update the CONTRIBUTING.md
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  8. Merge pull request moby#39431 from thaJeztah/macvlan_redundant_checks

    thaJeztah committed Jul 15, 2019
    Integration: remove redundant kernel version check for MACVlan
  9. Merge pull request moby#37836 from selansen/test_initpool

    thaJeztah committed Jul 15, 2019
      TestServiceWithDefaultAddressPoolInit
Commits on Jul 14, 2019
  1. Merge pull request moby#39519 from thaJeztah/carry_38654

    thaJeztah committed Jul 14, 2019
    Fix indentation in some description [carry 38654]
  2. Merge pull request moby#39454 from crosbymichael/test-hc-stop

    thaJeztah committed Jul 14, 2019
    do not stop health check before sending signal
  3. Merge pull request moby#39485 from skanehira/master

    thaJeztah committed Jul 14, 2019
    fix swagger.yaml moby#39484
Commits on Jul 13, 2019
  1. Remove unused pkg/system.IsIoTCore()

    thaJeztah committed Oct 18, 2018
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  2. Remove skip evaluation of symlinks to data root on IoT Core

    thaJeztah committed Oct 11, 2018
    This fix was added in 8e71b1e to work around
    a go issue (golang/go#20506).
    
    That issue was fixed in
    golang/go@66c03d3,
    which is part of Go 1.10 and up. This reverts the changes that were made in
    8e71b1e, and are no longer needed.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  3. Merge pull request moby#39481 from KentaTada/use-memavailable

    thaJeztah committed Jul 13, 2019
    Use MemAvailable instead of MemFree to estimate actual available memory
  4. Integration: MACVlan add missing import comment and build-tag

    thaJeztah committed Jun 28, 2019
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  5. Integration: remove redundant kernel version check for MACVlan

    thaJeztah committed Jun 28, 2019
    The daemon requires kernel 3.10 or up to start, so there's no need
    to check if the daemon is kernel 3.8 or up.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  6. Merge pull request moby#39430 from thaJeztah/ipvlan_checks_cleanup

    thaJeztah committed Jul 13, 2019
    Integration: remove redundant checks in IPVLAN tests
  7. integration: fix cleanup of raft data

    thaJeztah committed Jul 12, 2019
    The directory used for storage was either changed or new directories
    were added.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  8. daemon: don't listen on the same address multiple times

    thaJeztah committed Jul 12, 2019
    Before this change:
    
        dockerd -H unix:///run/docker.sock -H unix:///run/docker.sock -H unix:///run/docker.sock
        ...
        INFO[2019-07-13T00:02:36.195090937Z] Daemon has completed initialization
        INFO[2019-07-13T00:02:36.215940441Z] API listen on /run/docker.sock
        INFO[2019-07-13T00:02:36.215933172Z] API listen on /run/docker.sock
        INFO[2019-07-13T00:02:36.215990566Z] API listen on /run/docker.sock
    
    After this change:
    
        dockerd -H unix:///run/docker.sock -H unix:///run/docker.sock -H unix:///run/docker.sock
        ...
        INFO[2019-07-13T00:01:37.533579874Z] Daemon has completed initialization
        INFO[2019-07-13T00:01:37.567045771Z] API listen on /run/docker.sock
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  9. DockerSwarmSuite lock portIndex to work around race

    thaJeztah committed Jul 13, 2019
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  10. Merge pull request moby#39517 from cpuguy83/troubleshoot_more_noise

    thaJeztah committed Jul 13, 2019
    Fix Microsecond -> Millisecond.
Commits on Jul 12, 2019
  1. Merge pull request moby#39506 from thaJeztah/group_test_subdirs

    thaJeztah committed Jul 12, 2019
    integration: organize bundle directory per test
  2. Merge pull request moby#39508 from thaJeztah/fix_remove_bundles

    thaJeztah committed Jul 12, 2019
    Fix "Removing bundles/" not actually removing bundles
  3. Fix "Removing bundles/" not actually removing bundles

    thaJeztah committed Jul 12, 2019
    Before:
    
    Running `ls -la bundles/` before, and after removing:
    
        ls -la bundles/
        total 16
        drwxr-xr-x  7 root root  224 Jul 12 12:25 .
        drwxr-xr-x  1 root root 4096 Jul 12 12:30 ..
        drwxr-xr-x  2 root root   64 Jul 12 10:00 dynbinary
        drwxr-xr-x  6 root root  192 Jul 12 12:25 dynbinary-daemon
        lrwxrwxrwx  1 root root    1 Jul 12 12:25 latest -> .
        drwxr-xr-x 92 root root 2944 Jul 12 12:29 test-integration
    
        Removing bundles/
    
        ls -la bundles/
        total 16
        drwxr-xr-x  7 root root  224 Jul 12 12:25 .
        drwxr-xr-x  1 root root 4096 Jul 12 12:30 ..
        drwxr-xr-x  2 root root   64 Jul 12 10:00 dynbinary
        drwxr-xr-x  6 root root  192 Jul 12 12:25 dynbinary-daemon
        lrwxrwxrwx  1 root root    1 Jul 12 12:25 latest -> .
        drwxr-xr-x 92 root root 2944 Jul 12 12:29 test-integration
    
    After:
    
    Running `ls -la bundles/` before, and after removing:
    
        ls -la bundles/
        total 16
        drwxr-xr-x  7 root root  224 Jul 12 12:25 .
        drwxr-xr-x  1 root root 4096 Jul 12 12:30 ..
        drwxr-xr-x  2 root root   64 Jul 12 10:00 dynbinary
        drwxr-xr-x  6 root root  192 Jul 12 12:25 dynbinary-daemon
        lrwxrwxrwx  1 root root    1 Jul 12 12:25 latest -> .
        drwxr-xr-x 92 root root 2944 Jul 12 12:29 test-integration
    
        Removing bundles/
    
        ls -la bundles/
        total 4
        drwxr-xr-x 2 root root   64 Jul 12 12:25 .
        drwxr-xr-x 1 root root 4096 Jul 12 12:30 ..
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  4. Cleanup "address" when connecting over a UNIX socket

    thaJeztah committed Jul 12, 2019
    When connecting with the daemon using a UNIX socket, the HTTP hostname was set, based
    on the socket location, which was generating some noise in the test-logs.
    
    Given that the actual hostname is not important (the URL just has to be well-formed),
    the hostname/address can be cleaned up to reduce the noise.
    
    This patch strips the path from the `addr`, and keeps `<random-id>.sock` as address.
    
    Before:
    
        daemon.go:329: [d15d31ba75501] error pinging daemon on start: Get http://%2Ftmp%2Fdocker-integration%2Fd15d31ba75501.sock/_ping: dial unix /tmp/docker-integration/d15d31ba75501.sock: connect: no such file or directory
    
    After:
    
        daemon.go:329: [d15d31ba75501] error pinging daemon on start: Get http://d15d31ba75501.sock/_ping: dial unix /tmp/docker-integration/d15d31ba75501.sock: connect: no such file or directory
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  5. Harden TestClientWithRequestTimeout

    thaJeztah committed Apr 18, 2019
    DeadlineExceeded now implements a TimeOut() function,
    since golang/go@dc4427f
    
    Check for this interface, to prevent possibly incorrect failures;
    
    ```
    00:16:41 --- FAIL: TestClientWithRequestTimeout (0.00s)
    00:16:41     client_test.go:259: assertion failed:
    00:16:41         --- context.DeadlineExceeded
    00:16:41         +++ err
    00:16:41         :
    00:16:41         	-: context.deadlineExceededError{}
    00:16:41         	+: &net.OpError{Op: "dial", Net: "tcp", Addr: s"127.0.0.1:49294", Err: &poll.TimeoutError{}}
    00:16:41
    ```
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  6. integration: organize bundle directory per test

    thaJeztah committed Jul 12, 2019
    The test-integration/test=integration-cli directory contains
    a directory for each daemon that was created during the integration
    tests, which makes it a long list to browse through. In addition,
    some tests spin up multiple daemons, and when debugging test-failures,
    the daemon-logs often have to be looked at together.
    
    This patch organizes the bundl directory to group daemon storage
    locationos per test, making it easier to find information about
    all the daemons that were used in a specific test.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Older
You can’t perform that action at this time.