Skip to content

/ Thali_CordovaPlugin

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest JXCore Cordova Plugin #108

Closed
yaronyg opened this issue Sep 8, 2015 · 9 comments
Closed

Update to latest JXCore Cordova Plugin #108

yaronyg opened this issue Sep 8, 2015 · 9 comments
Assignees
@tobybrad
Milestone
0.0.1 - Identity ...

Comments

@yaronyg
Copy link
Member

@yaronyg yaronyg commented Sep 8, 2015

We have a new release - https://github.com/jxcore/jxcore-cordova-release and we need to update to it.
@yaronyg yaronyg added this to the 0.0 - Bring in the public keys milestone Sep 8, 2015
@yaronyg
Copy link
Member Author

@yaronyg yaronyg commented Sep 15, 2015

@tobybrad do we want to do this now or wait until after 0.0.1? I'm tempting to wait but if we run into any issues then JXcore can't help us until we upgrade to the latests and greatest. Thoughts?
@obastemur
Copy link
Contributor

@obastemur obastemur commented Sep 16, 2015

Upgrade doesn't require any update on source code level.
@tobybrad
Copy link
Contributor

@tobybrad tobybrad commented Sep 16, 2015

@yaronyg Do it for 0.0.1. This fixes a leak iirc. Not a major change, but a useful one.
@yaronyg yaronyg assigned yaronyg and unassigned tobybrad Sep 16, 2015
@yaronyg
Copy link
Member Author

@yaronyg yaronyg commented Sep 16, 2015

It shall be done.
@obastemur
Copy link
Contributor

@obastemur obastemur commented Sep 19, 2015

BTW; although 0.0.5 is not stable yet, better target that version for configuration free ios9 compatibility + fix for some Samsung devices.
@obastemur
Copy link
Contributor

@obastemur obastemur commented Sep 19, 2015

By saying not stable, There are some core changes but no significant issue is expected.
@yaronyg
Copy link
Member Author

@yaronyg yaronyg commented Oct 13, 2015

We need to do it again for Cordova 0.0.7 - the main feature is that you can now turn off WiFi on Android from Node.js
@yaronyg yaronyg added the ready label Oct 13, 2015
@yaronyg yaronyg assigned tobybrad and unassigned yaronyg Oct 19, 2015
@yaronyg
Copy link
Member Author

@yaronyg yaronyg commented Oct 19, 2015

I believe @tobybrad is already working on this.
@yaronyg yaronyg added in progress and removed ready labels Oct 19, 2015
@tobybrad
Copy link
Contributor

@tobybrad tobybrad commented Oct 20, 2015

https://github.com/thaliproject/Thali_CordovaPlugin/blob/cle_fixes/thali/install/install.js#L274
@tobybrad tobybrad closed this Oct 20, 2015
@tobybrad tobybrad removed the in progress label Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobybrad tobybrad

Labels
None yet
Projects
None yet
Milestone
0.0.1 - Identity ...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@yaronyg @obastemur @tobybrad
You can’t perform that action at this time.